Side Navigation customization #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
…de-navigation--x]Props
…iTwin/iTwinUI into xander/side-navigation--x]Props
xman343
requested review from
mayank99 and
adamhock
and removed request for
a team
mayank99
reviewed
Aug 2, 2023
packages/itwinui-react/src/core/SideNavigation/SideNavigation.tsx
Outdated
Show resolved
Hide resolved
packages/itwinui-react/src/core/SideNavigation/SideNavigation.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
adamhock
reviewed
Aug 2, 2023
packages/itwinui-react/src/core/SideNavigation/SideNavigation.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This reverts commit 2eae953.
|
Reverted the changes that were meant for another PR. Should work now |
…iTwin/iTwinUI into xander/side-navigation--x]Props
mayank99
approved these changes
Aug 14, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1368 - Improving customization of
SideNavigationcomponent.Testing
Will be tested thru unit & visual testing.
Docs
TBD