make theme='inherit' the default
#1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
gretanausedaite and
rohan-kadkol
and removed request for
a team
gretanausedaite
approved these changes
Aug 9, 2023
rohan-kadkol
reviewed
Aug 9, 2023
packages/itwinui-react/src/core/ThemeProvider/ThemeProvider.tsx
Outdated
Show resolved
Hide resolved
| @@ -124,6 +133,8 @@ export const ThemeProvider = React.forwardRef((props, ref) => { | |||
|
|
|||
| export default ThemeProvider; | |||
|
|
|||
| // ---------------------------------------------------------------------------- | |||
|
|
|||
| const Root = React.forwardRef((props, forwardedRef) => { | |||
There was a problem hiding this comment.
nit: Might help to explain what is the purpose of Root, even though it is not exported.
There was a problem hiding this comment.
it was not added in this PR though.
rohan-kadkol
reviewed
Aug 9, 2023
packages/itwinui-react/src/core/ThemeProvider/ThemeProvider.tsx
Outdated
Show resolved
Hide resolved
rohan-kadkol
approved these changes
Aug 9, 2023
rohan-kadkol
reviewed
Aug 9, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
changed default value of
ThemeProvidersthemeprop to"inherit"(previously"light").improved the handling of
"inherit"so that it does three things (in order):data-iui-themeattribute if no context foundas a result, developers will be able to use v3
ThemeProviderinside v2ThemeProviderand it will automatically work. also,data-iui-themecan be set on the<body>(standalone@itwin/itwinui-variablesusage) and it will automatically be respected.Testing
tested in playground and updated unit tests.
Docs
added changeset.