Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a11y violations for Tile examples #1493

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Fixed a11y violations for Tile examples #1493

merged 8 commits into from
Aug 16, 2023

Conversation

r100-stack
Copy link
Member

Changes

Added aria-label to <Tile.IconButton> in TileMainExample.

Testing

Confirmed that the cypress-axe TileMainExample test passes.

Docs

N/A

@r100-stack r100-stack self-assigned this Aug 14, 2023
@r100-stack r100-stack added the a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) label Aug 14, 2023
@r100-stack r100-stack marked this pull request as ready for review August 14, 2023 22:00
@r100-stack r100-stack requested review from a team as code owners August 14, 2023 22:00
@r100-stack r100-stack requested review from gretanausedaite and removed request for a team August 14, 2023 22:00
@r100-stack r100-stack mentioned this pull request Aug 14, 2023
Open
23 tasks
mayank99
mayank99 reviewed Aug 15, 2023
View reviewed changes
examples/Tile.main.tsx Outdated Show resolved Hide resolved
packages/itwinui-react/src/core/Tree/TreeNode.tsx Outdated Show resolved Hide resolved
@r100-stack r100-stack changed the base branch from dev to rohan/a11y-violations-tree August 15, 2023 17:53
Base automatically changed from rohan/a11y-violations-tree to dev August 15, 2023 17:56
mayank99
mayank99 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after branch is updated and merge conflicts resolved.

@r100-stack r100-stack added this pull request to the merge queue Aug 16, 2023
Merged via the queue into dev with commit ada76e3 Aug 16, 2023
15 of 16 checks passed
@r100-stack r100-stack deleted the rohan/a11y-violations-tile branch August 16, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayank99 mayank99 mayank99 approved these changes

@gretanausedaite gretanausedaite Awaiting requested review from gretanausedaite gretanausedaite was automatically assigned from iTwin/itwinui-1

Assignees

@r100-stack r100-stack

Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r100-stack @mayank99