added label to TransferListMain example. #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhantrawal
requested review from
mayank99 and
r100-stack
and removed request for
a team
23 tasks
mayank99
reviewed
Aug 31, 2023
siddhantrawal
changed the title
mayank99
approved these changes
Aug 31, 2023
siddhantrawal
added
the
a11y
r100-stack
reviewed
Sep 1, 2023
There was a problem hiding this comment.
There is no difference between the TransferList.main and TransferList.withlabel. Also, if the label is required, then "With Label" is no longer a variant; it is the default.
@mayank99, was there a reason why these two nearly identical examples existed? Were we planning to document more variants in the future? If there's no special reason, let's remove this TransferList.withLabel along with the "Variants" headings.
r100-stack
approved these changes
Sep 1, 2023
Agreed, we can remove the "withlabel" example, and document that labels should always be provided. |
siddhantrawal
deleted the
siddhant/added-area-label-TransferListMainExample
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added area-label to TransferListMain example. Fixed a11y violation.
Testing
Before:
After:
Docs
N/A