Update icon placement in LabeledInput/LabeledTextarea #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretanausedaite
requested review from
mayank99 and
rohan-kadkol
and removed request for
a team
mayank99
reviewed
Sep 5, 2023
mayank99
approved these changes
Sep 5, 2023
rohan-kadkol
approved these changes
Sep 5, 2023
| @@ -124,7 +114,7 @@ export const LabeledInput = React.forwardRef((props, ref) => { | |||
| ref={ref} | |||
| {...rest} | |||
| /> | |||
| {icon && iconDisplayStyle === 'inline' && ( | |||
| {(svgIcon || (svgIcon !== null && status && !message)) && ( | |||
There was a problem hiding this comment.
nit: Since there are many if statements here, would be helpful if you add a comment.
There was a problem hiding this comment.
can also be moved to a variable for readability
const shouldShowIcon = svgIcon !== null && (svgIcon || (status && !message));There was a problem hiding this comment.
Added fancy condition variable for readability
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed iconDisplayStyle;
svgIcon is being rendered inline;
Users must use StatusMessage to add custom icon to the message;
Testing
Updated images for status input and textarea;
Docs
Changeset added;