restore old Breadcrumbs api #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
gretanausedaite and
rohan-kadkol
and removed request for
a team
gretanausedaite
approved these changes
Sep 12, 2023
| * const logWarningInDev = createWarningLogger(); | ||
| * logWarningInDev("please don't use this") | ||
| */ | ||
| const createWarningLogger = !isDev |
rohan-kadkol
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
undoes the breaking change from #1369 using
children.typeandchildren.props.both of these apis are brittle and not really recommended, so i'm logging a warning to encourage using the new api. we can also auto-convert to the new api in our codemod.
Testing
added unit test for it.
Docs
since there is no real benefit to using the old api (it's not any less verbose), i'm not documenting it anywhere.