-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
use popover
API in Tooltip
if supported
#2060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
May 22, 2024 18:15
Ben-Pusey-Bentley
approved these changes
May 22, 2024
r100-stack
reviewed
May 23, 2024
r100-stack
reviewed
May 23, 2024
r100-stack
approved these changes
May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When supported,
popover=manual
will be used to show the tooltip in the top-layer. In non-supported browsers, the attribute is ignored.In addition to the
popover
attribute itself, there are only two changes:togglePopover
whenever the React state changes.?.
for supporting older browsers.:popover-open
doesn't match.I kept the existing mechanism (
Portal
component,z-index
property,hidden
attribute), soTooltip
will continue to work in browsers that don't support popover.Testing
All existing tests pass 馃殌
Tested manually that hover/focus behaviors are intact and that the tooltip does indeed show in the top layer (This can be verified in Chrome dev tools, for example). Also emulated older browsers by commenting out
popover
and testing that it works fine.Updated unit tests to simply check for the presence of the
popover
attribute. I spent some time looking into adding tests fortogglePopover
without success, since JSDOM doesn't support it. This is not a big deal imo; the visual tests already serve as a way to ensure that the tooltip is working.Docs
Added changesets for both CSS and React.
Updated Tooltip documentation to mention that portaling is useful only in browsers that don't support
popover
.