Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insights client rewrite #13

Merged
merged 65 commits into from
Aug 23, 2022
Merged

Insights client rewrite #13

merged 65 commits into from
Aug 23, 2022

Conversation

RytisSapka
Copy link
Contributor

No description provided.

@RytisSapka
Changed mandatory variables to not be optional.
37f84c3 
Split interfaces into different files.
@RytisSapka
Wrote getMappingsAsync function for async iteration.
6ee317a 
Rewrote getMappings function to use getMappingsAsync.
Fixed some code formatting mistakes.
@RytisSapka
Implemented async data retrieval
f3bed36 
Modified comments
@RytisSapka
Moved fetch process from api to reportingClient
74704c1 
Decluttered code
@RytisSapka
extraction logs collection name discrepancy fix
dfdbec5
@RytisSapka
moved get single and create methods to reportingClient
8b5d0ef
@RytisSapka
Moved all methods but one from api to ReportingClient
c08aafd
@RytisSapka
Changed structure of project
230b95c
@RytisSapka
test coverage config
be033ec
@RytisSapka
deleted api file
6ab3539
@RytisSapka
config update for tests
c94c247
@RytisSapka
test gets auth token
23725e0
@RytisSapka
comments and interface for iterators
c3ac026
@RytisSapka
working tests
c7ce836
@RytisSapka
fixed changeset info not appearing in lib
1201124
@RytisSapka
tests for extraction, odata and reports clients
b532c77
@RytisSapka
touch ups
0bfb642
@RytisSapka
fixed return types
4aed48a
@RytisSapka
working integration tests
75f25dc
@RytisSapka
added unit tests
29e7fb9
@RytisSapka
extractionClient integration test fix
d381a43
@RytisSapka
Removed unnecessary code from imodels client packages
dcb94e3
@RytisSapka
fixed directory layout
b0826b1
@RytisSapka
linter fixes
93f0c1f
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

MindaugasButkus
MindaugasButkus requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@MindaugasButkus MindaugasButkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review. I have not reviewed all changes yet.

tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/reporting/OperationsBase.ts Outdated Show resolved Hide resolved
src/reporting/OperationsBase.ts Outdated Show resolved Hide resolved
src/reporting/OperationsBase.ts Outdated Show resolved Hide resolved
src/reporting/OperationsBase.ts Outdated Show resolved Hide resolved
src/reporting/OperationsBase.ts Outdated Show resolved Hide resolved
@RytisSapka RytisSapka closed this Aug 23, 2022
@MindaugasButkus MindaugasButkus merged commit 769721e into iTwin:main Aug 23, 2022
@Guillar1
Copy link
Collaborator

Guillar1 commented Sep 1, 2022 •
edited

I just noticed the readme was not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guillar1 Guillar1 Guillar1 left review comments

@MindaugasButkus MindaugasButkus MindaugasButkus approved these changes

@bingjiez bingjiez Awaiting requested review from bingjiez

@arnobmallickbsw arnobmallickbsw Awaiting requested review from arnobmallickbsw arnobmallickbsw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RytisSapka @CLAassistant @MindaugasButkus @Guillar1