Need help on import Proteus (DEXPI) files to imodeljs

[NguyenBentley]

I try to import Proteus (DEXPI) files to imodeljs. A Proteus file defines a drawing sheet with a list of objects (presented in the sheet) with 1D & 2D properties

I know how to import the list of presented objects with 1D & 2D properties to imodeljs but do not know how to create a drawing sheet and to tell that the drawing include the objects with its own category. So 2 questions to you

1. How to create a drawing sheet (which to use: SectionDrawing or DrawingPartition or DrawingModel or … ?)
2. How to tell imodeljs, the sheet that I just created includes the list of the objects GeometricElement ...

Thank a lot

[NguyenBentley]

Please give me some help
You do not need to take time to give me the help. Some hints to a unit-test or integration-test or offline-test in the code of iModelJs are enough and helpful

[pmconne]

Sheets and drawings are two different kinds of 2d models. Can you specify which of those you mean by "drawing sheet"?

[NguyenBentley]

Thank for the answer. I talk about “Sheets and drawings” in the view of an user, not in the concept of iModelJS It is a sheet such as used in the P&ID: piping and instrumentation diagram (P&ID) [cid:image003.png@01D6C7E6.64A356C0] With best regards, Huu Dung Nguyen Siemens AG Digital Industries Process Automation Software Development 2 DI PA AE CIS SW 2 Karl-Legien-Str. 190 53117 Bonn, Germany Tel.: +49 228 64805-608 mailto:huu-dung.nguyen@siemens.com www.siemens.com<https://siemens.com> [cid:image004.gif@01D6C7E6.64A356C0] Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Jim Hagemann Snabe; Managing Board: Joe Kaeser, Chairman, President and Chief Executive Officer; Roland Busch, Klaus Helmrich, Cedrik Neike, Matthias Rebellius, Ralf P. Thomas, Judith Wiese; Registered offices: Berlin and Munich, Germany; Commercial registries: Berlin-Charlottenburg, HRB 12300, Munich, HRB 6684; WEEE-Reg.-No. DE 23691322 From: Paul Connelly <notifications@github.com> Sent: Tuesday, December 1, 2020 1:26 PM To: imodeljs/imodeljs <imodeljs@noreply.github.com> Cc: Nguyen, Huu Dung (DI PA AE CIS SW 2) <huu-dung.nguyen@siemens.com>; Author <author@noreply.github.com> Subject: Re: [imodeljs/imodeljs] Need help on import Proteus (DEXPI) files to imodeljs (#299) Sheets and drawings are two different kinds of 2d models. Can you specify which of those you mean by "drawing sheet"? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fimodeljs%2Fimodeljs%2Fdiscussions%2F299%23discussioncomment-143627&data=04%7C01%7Chuu-dung.nguyen%40siemens.com%7C0782f2ee015c4dfc976008d895f43b7e%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637424223488732194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=H7VGKSG4hTIwhHlD4ulLMPnzezkApS2kDBTgA0hMx4I%3D&reserved=0>, or unsubscribe<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARN3FTTWR6T4MXSLEEOKDWDSSTOEPANCNFSM4UAS4NYQ&data=04%7C01%7Chuu-dung.nguyen%40siemens.com%7C0782f2ee015c4dfc976008d895f43b7e%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637424223488732194%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7UjXSN3pALoQVSacwGdDw9bM8KwilytbytEToJwA0mY%3D&reserved=0>.

[pmconne]

Your image is not viewable. It sounds like you want to create a DrawingModel. Here is a simple example.

[NguyenBentley]

I resend you the image [cid:image001.png@01D6C7E8.6B207E40] Please tell me if it is visible With best regards, Huu Dung Nguyen Siemens AG Digital Industries Process Automation Software Development 2 DI PA AE CIS SW 2 Karl-Legien-Str. 190 53117 Bonn, Germany Tel.: +49 228 64805-608 mailto:huu-dung.nguyen@siemens.com www.siemens.com<https://siemens.com> [cid:image002.gif@01D6C7E8.6B207E40] Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Jim Hagemann Snabe; Managing Board: Joe Kaeser, Chairman, President and Chief Executive Officer; Roland Busch, Klaus Helmrich, Cedrik Neike, Matthias Rebellius, Ralf P. Thomas, Judith Wiese; Registered offices: Berlin and Munich, Germany; Commercial registries: Berlin-Charlottenburg, HRB 12300, Munich, HRB 6684; WEEE-Reg.-No. DE 23691322 From: Paul Connelly <notifications@github.com> Sent: Tuesday, December 1, 2020 1:42 PM To: imodeljs/imodeljs <imodeljs@noreply.github.com> Cc: Nguyen, Huu Dung (DI PA AE CIS SW 2) <huu-dung.nguyen@siemens.com>; Author <author@noreply.github.com> Subject: Re: [imodeljs/imodeljs] Need help on import Proteus (DEXPI) files to imodeljs (#299) Your image is not viewable. It sounds like you want to create a DrawingModel. Here is a simple example<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fimodeljs%2Fimodeljs%2Fblob%2F281b056bee13b6623b27c39f1c20181ee6ae4cc7%2Fcore%2Fbackend%2Fsrc%2Ftest%2FIModelTestUtils.ts%23L324&data=04%7C01%7Chuu-dung.nguyen%40siemens.com%7C48d2ee47de0340f248c608d895f684ac%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637424233302373023%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EIzJZZppzUi6i6cjz%2FOQgFnTlsk7BRS%2Bs2PdxkI5NUA%3D&reserved=0>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fimodeljs%2Fimodeljs%2Fdiscussions%2F299%23discussioncomment-143707&data=04%7C01%7Chuu-dung.nguyen%40siemens.com%7C48d2ee47de0340f248c608d895f684ac%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637424233302373023%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2B0tNIJPsoizPp%2Fe7DcnGQGUI7TQj9UmnfGKU88GThVE%3D&reserved=0>, or unsubscribe<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARN3FTS2TUGXWDQ3YLVU5QDSSTQBZANCNFSM4UAS4NYQ&data=04%7C01%7Chuu-dung.nguyen%40siemens.com%7C48d2ee47de0340f248c608d895f684ac%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637424233302383010%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Kt3i%2FDhioHCpalF41k9m1704ntAqiV0eYy1tlCi7vJU%3D&reserved=0>.

[pmconne]

It is not. I know what a P&ID looks like though. Consider replying on github instead of via email.

[NguyenBentley]

OK i resend it
As i understand do you mind that i should take
public static createAndInsertDrawingPartitionAndModel(...) ?

[pmconne]

I linked to that code as an example of how to create a drawing partition and model. If you have more specific questions, please ask.

[NguyenBentley]

What i would like to ask is:
how to insert a P&ID sheet to iModelJS,
how to set the extent of the sheet
and tell the sheet should include these GeometricElements

Is there any unit-test for that ?

[pmconne]

You add elements to a model by inserting them into that model. An element resides in exactly one model - you tell us the Id of the target model when you insert the element. When we display the model, we draw all of the elements in that model.
The extents of the model are computed as the union of the range of all elements in that model - you do not need to explicitly set them.

[NguyenBentley]

That means that i create a createAndInsertDrawingModel() and insert element to this model ? What is about category ?

[pmconne]

What is about category ?

What about it? Every geometric element belongs to a Category. As with the model Id, you tell us the category Id when you insert the element.

[pmconne]

Further info about categories.

[pmconne]

Further info about geometric element properties used to insert a geometric element.

[NguyenBentley]

I take the test in \imodeljs\core\backend\src\test\standalone\GeometryStream.test.ts
e.g.
function createGeometricElem(geom: GeometryStreamProps, placement: Placement3dProps, imodel: SnapshotDb, seedElement: GeometricElement): Id64String {
const elementProps: PhysicalElementProps = {
classFullName: PhysicalObject.classFullName,
model: seedElement.model,
category: seedElement.category,
code: Code.createEmpty(),
geom,
placement,
};
const el = imodel.elements.createElement(elementProps);
return imodel.elements.insertElement(el);
}
to create and insert the elements. Is it OK

[pmconne]

That code is creating a PhysicalElement, which is 3d.

[NguyenBentley]

I will change it e.g. to

const elementProps: GeometricElementProps = {
classFullName: PhysicalObject.classFullName,
model: seedElement.model,
category: seedElement.category,
code: Code.createEmpty(),
geom,
placement,
};
const el = imodel.elements.createElement(elementProps);
return imodel.elements.insertElement(el);
}

[pmconne]

That will not help - look at your classFullName. I am trying to track down some example code for you.

[NguyenBentley]

This is the point of my trouble. i think i can insert any classFullName then the drawing mode is intelligent to take only what it can. It is IMHO only a name, what does imodeljs do with classFullName

[pmconne]

classFullName tells us what kind of element you are creating. Are you familiar with BIS? A DrawingModel contains elements of class DrawingGraphic. Attempting to insert a PhysicalElement into a DrawingModel will produce an error.

[NguyenBentley]

Not so much familiar with BIS
So as i understand i should create a DrawingModel then add instances of GeometricElementProps with classFullName= DrawingGraphic.classFullName and that is all for a PID sheet ?

[NguyenBentley]

As you said: " I am trying to track down some example code for you" can i expect to get some sample code to day ? Thank a lot
I get so much error with the insert of PhysicalObject.classFullName but do not know why ?

[scsewall]

@NguyenBentley We will keep looking for a better example, but this function shows how to create many different Element types:

https://github.com/imodeljs/imodeljs/blob/a6cc6700f80ec0afa4ba55aea274561c4ffea8ff/core/backend/src/test/IModelTransformerUtils.ts#L45

[NguyenBentley]

Please answer me if i am wrong:
for a PID sheet , i should create a DrawingModel then add instances of GeometricElement2dProps with classFullName= DrawingGraphic.classFullName

[scsewall]

@NguyenBentley You are correct for the "drawing" part of a P&ID. However, those DrawingGraphics should also have relationships to elements from a Plant schema. Someone from the Plant team will need to chime in to help there.

[NguyenBentley]

"elements from a Plant schema": Do you mind the 1D data of the FunctionalModel ?

[scsewall]

Yes, that is what I meant.

[NguyenBentley]

Thank
I will do it step by step, first PID sheet with 2D GeometricElement2dProps elements then relation to 1D data