Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RPC memory leak #1044

Merged
merged 23 commits into from
Mar 30, 2021
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
17ee7a3
Clear current invocation once resolved
swbsi Mar 25, 2021
ea4ffc0
Change
swbsi Mar 25, 2021
b16bbc9
Merge branch 'master' into rpc-leak
mergify[bot] Mar 25, 2021
7098b16
Merge branch 'master' into rpc-leak
mergify[bot] Mar 25, 2021
00f4d5b
Merge branch 'master' into rpc-leak
mergify[bot] Mar 25, 2021
295f480
Merge branch 'master' into rpc-leak
mergify[bot] Mar 25, 2021
ed3bd83
Merge branch 'master' into rpc-leak
mergify[bot] Mar 26, 2021
023ee63
Merge branch 'master' into rpc-leak
mergify[bot] Mar 26, 2021
ad5c93b
Merge branch 'master' into rpc-leak
mergify[bot] Mar 26, 2021
a636786
Merge branch 'master' into rpc-leak
mergify[bot] Mar 26, 2021
b595387
Merge branch 'master' into rpc-leak
mergify[bot] Mar 26, 2021
e894306
Merge branch 'master' into rpc-leak
mergify[bot] Mar 26, 2021
4bf2012
Merge branch 'master' into rpc-leak
mergify[bot] Mar 27, 2021
f4417f5
Merge branch 'master' into rpc-leak
mergify[bot] Mar 27, 2021
1ac1c13
Merge branch 'master' into rpc-leak
mergify[bot] Mar 28, 2021
fb2e20b
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
7255cd0
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
513a159
Interfaces may not be registered -- unauthorized access or tests scen…
swbsi Mar 29, 2021
d49811a
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
9f6a29d
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
24a83e3
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
5ee61d5
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
59aa7d2
Merge branch 'master' into rpc-leak
mergify[bot] Mar 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@bentley/imodeljs-common",
"comment": "Memory leak fix",
"type": "none"
}
],
"packageName": "@bentley/imodeljs-common",
"email": "69857376+swbsi@users.noreply.github.com"
}
7 changes: 7 additions & 0 deletions core/common/src/rpc/core/RpcInvocation.ts
Expand Up @@ -227,6 +227,13 @@ export class RpcInvocation {
interfaceName: (typeof (this.operation) === "undefined") ? "" : this.operation.interfaceDefinition.interfaceName,
};

try {
const impl = RpcRegistry.instance.getImplForInterface(this.operation.interfaceDefinition) as any;
if (impl[CURRENT_INVOCATION] === this) {
impl[CURRENT_INVOCATION] = undefined;
}
} catch (_err) { }

return fulfillment;
}

Expand Down