Support per-model display settings for batched tiles #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconne
requested review from
a team,
bbastings,
danieliborra,
dassaf4,
saeeedtorabi,
aruniverse and
ben-polinsky
as code owners
…win/itwinjs-core into pmc/batched-tile-model-groups
dassaf4
approved these changes
Jan 17, 2024
markschlosseratbentley
approved these changes
Jan 17, 2024
danieliborra
approved these changes
Jan 17, 2024
ben-polinsky
approved these changes
Jan 17, 2024
aruniverse
approved these changes
Jan 17, 2024
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
|
ImageTests results: some slight z-fighting changes in AnimatedCastle and fixes to plan projections in GeoBridgeDemo and FloridaGIS. @DStradley fyi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6340.
Group models that have compatible display settings, then produce a tile tree reference for each group.
When decoding tiles, split the contents based on those groupings.
In typical cases, only one group exists so no tile splitting occurs.
When the display settings change, re-evaluate the groupings and, if they've changed, produce new tile tree references.
The
BENTLEY_BatchedTileSetextension is now required; it provides the Id, extents, and view flag overrides for every model included in the tileset. Implemented in https://github.com/iTwin/imodel-native-internal/pull/355 which should be merged simultaneously with this PR.After a viewer upgrades to this version of the @itwin/frontend-tiles package, any tilesets published by an older version of TilesetPublisher will fail to load due to the absence of the metadata described above.
TODO: