Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a few of PolyfaceQuery functions around to make the code more readable #6741

Merged
merged 5 commits into from
May 22, 2024

Conversation

saeeedtorabi
Copy link
Contributor

Also fixed a couple lint issues

Copy link
Member

@dassaf4 dassaf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming no modifications made to moved code.

@dassaf4
Copy link
Member

dassaf4 commented May 22, 2024

Looks like CI wants the rushchange file.

@saeeedtorabi
Copy link
Contributor Author

Approved, assuming no modifications made to moved code.

Yes, no code change

@saeeedtorabi
Copy link
Contributor Author

Looks like CI wants the rushchange file.

oh I missed running it. Will send a new commit

@saeeedtorabi saeeedtorabi enabled auto-merge (squash) May 22, 2024 13:30
@saeeedtorabi saeeedtorabi merged commit 3e187e3 into master May 22, 2024
16 checks passed
@saeeedtorabi saeeedtorabi deleted the saeed-torabi/polyface-query-reorder branch May 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants