Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to latest reality-data-client pkg #6766

Merged
merged 5 commits into from
May 29, 2024
Merged

update to latest reality-data-client pkg #6766

merged 5 commits into from
May 29, 2024

Conversation

aruniverse
Copy link
Member

No description provided.

@aruniverse aruniverse requested review from a team as code owners May 28, 2024 20:41
@aruniverse aruniverse enabled auto-merge (squash) May 28, 2024 20:41
pmconne
pmconne approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@pmconne pmconne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes integration test failure?

@aruniverse
Copy link
Member Author

Fixes integration test failure?

Not necessarily fixed by this PR. But they have been fixed.
It was a permission issue, where a certain realitydata permission was removed from the integration test user

@aruniverse
Copy link
Member Author

@mcote01 tests are failing again now? Did you change the permissions again?

@mcote01
Copy link
Contributor

mcote01 commented May 28, 2024 •
edited
Loading

@aruniverse I set permissions again to the test user, should wait a few minutes for service caches to clear and then try running tests again

@aruniverse
Copy link
Member Author

@aruniverse I set permissions again to the test user, should wait a few minutes for service caches to clear and then try running tests again

It is still failing. Any idea what's going on?

I will skip this test if it continues to fsil today because it's been blocking every pr since mid last week

@pmconne
Copy link
Member

pmconne commented May 29, 2024 •
edited
Loading

I will skip this test if it continues to fsil today

Please do. We can force-merge normal PRs to bypass it but it's going to block the publication of new addons, which is expected to happen today.

@aruniverse aruniverse mentioned this pull request May 29, 2024
Closed
@aruniverse aruniverse merged commit e4a88f5 into master May 29, 2024
13 of 14 checks passed
@aruniverse aruniverse deleted the update/rd-client branch May 29, 2024 14:31
hl662 pushed a commit that referenced this pull request Jun 3, 2024
@aruniverse @hl662
update to latest reality-data-client pkg (#6766)
9cf0c5a 
Co-authored-by: Arun George <aruniverse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconne pmconne pmconne approved these changes

@hl662 hl662 hl662 approved these changes

@DStradley DStradley Awaiting requested review from DStradley DStradley is a code owner automatically assigned from iTwin/itwinjs-core

@evelynpreslar-bentley evelynpreslar-bentley Awaiting requested review from evelynpreslar-bentley evelynpreslar-bentley is a code owner automatically assigned from iTwin/itwinjs-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aruniverse @mcote01 @pmconne @hl662