Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow App to specify GCS asset Dir #6825

Closed
wants to merge 6 commits into from
Closed

Conversation

DanRod1999
Copy link
Contributor

@DanRod1999 DanRod1999 commented Jun 11, 2024

imodel-native: iTwin/imodel-native#748
resolves: https://github.com/iTwin/itwinjs-backlog/issues/1134

Be able to specify the location for GCS data in the native code when gcs workspaces are disabled. Visualization/GPB want to use it when loading up GPB in the kubernetes clusters. This is related to one of the experiments during the pineapple viewer hackathon.

@kabentley
Copy link
Contributor

I don't understand the reason for this PR (the link above doesn't work for me). What is a "geocoord asset dir" and why does anyone need it?

@DanRod1999
Copy link
Contributor Author

I don't understand the reason for this PR (the link above doesn't work for me). What is a "geocoord asset dir" and why does anyone need it?

Geocoord asset Dir, is what I'm calling the local directory storing GCS data.
We found a perf hit during imodel opens, and it was due to demands on GCS data. To avoid this the idea was to disable workspaces in GBP in the Kubernetes clusters, and package the GCS data on the nodes and mount the path of the GCS data to all the nodes on the cluster.
Typically when workspaces are disabled it defaults to the asset directory setup in IKnownLocationsAdmin, and when stored in the addon the path is something like .../@bentley+imodeljs-native@4.5.38 which due to the change versions would require editing the mounted path every time. So to prevent that we wanted the ability to specify the path we store the gcs data

@pmconne
Copy link
Member

pmconne commented Jun 12, 2024

We found a perf hit during imodel opens

Can you quantify this perf hit? Host many seconds will you save by making the proposed change?

@kabentley
Copy link
Contributor

Of course the only performance improvement is startup time, and I'm skeptical this will help much, but I would like to understand where the time actually goes.

But, I spoke to @wgoehrig about this and explained there is no need to re-open this old wound - just use local WorkspaceDb file(s) and the existing api works just fine. Reading loose CSMap files should be permanently removed from the code.

@DanRod1999 DanRod1999 closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants