Cancel hilite set request on selection change #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
saskliutas
commented
Nov 27, 2023
packages/components/src/presentation-components/viewport/ViewportSelectionHandler.ts
Outdated
Show resolved
Hide resolved
grigasp
requested changes
Nov 28, 2023
packages/components/src/presentation-components/viewport/WithUnifiedSelection.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/presentation-components/viewport/ViewportSelectionHandler.ts
Outdated
Show resolved
Hide resolved
packages/components/src/presentation-components/viewport/ViewportSelectionHandler.ts
Outdated
Show resolved
Hide resolved
packages/components/src/test/viewport/WithUnifiedSelection.test.tsx
Outdated
Show resolved
Hide resolved
grigasp
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #329
Use new
getHiliteSetIteratorAPI to highlight elements on unified selection change. This new implementation cancels ongoing hilite set request when unified selection changes again.