Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateless tree hierarchy level filtering #447

Merged
merged 52 commits into from Mar 5, 2024
Merged

Stateless tree hierarchy level filtering #447

merged 52 commits into from Mar 5, 2024

Conversation

saskliutas
Copy link
Member

Closes #377

NodeSelectQueryFactory.createFilterClauses takes content class with alias. GenericInstanceFilterRule also has alias of the property source and it might not be the same as content class alias. Maybe we should override all rules with default this alias to use content class alias?

saskliutas and others added 30 commits February 13, 2024 14:04
@saskliutas
Initial
4c04a27
@saskliutas
Reload tree
2e363bd
@saskliutas
Update test-app
e249842
@JonasDov
Merge branch 'master' into stateless_tree_api
fde2a16
@JonasDov
set enableVirtualization to true
83350e4
@JonasDov
remove produce()
75f224a
@saskliutas
Merge branch 'master' into stateless_tree_api
7377ab3
@saskliutas
Add unified selection to tree
14b99b7
@saskliutas
Fix presentation data localization
074334f
@saskliutas
Bump itwinUI
fc05e6c
@saskliutas
Fix tree model reload
2bce893
@saskliutas
Split code
4fa702b
@saskliutas
Persist tree state between searches
71f9576
@saskliutas
Add ability to remove hierarchy level limit
0dc37b3
@saskliutas
Persist selection
6ba0e4a
@saskliutas
Cleanup tree component
e8e6d4b
@saskliutas
Merge branch 'master' into stateless_tree_api
8a3de26
@saskliutas
Cleanup TreeWidget component
b557a6b
@saskliutas
Cleanup Tree API
f3175a7
@saskliutas
Update itwinui-react
cebf3a8
@saskliutas
Copy all assets from dependencies
4e83731
@saskliutas
Fix assets copying
03e40fe
@saskliutas
Fix assets copying again
8913c75
@saskliutas
Fix trees layout
4de54dd
@saskliutas
Switch to unified selection
03763f3
@saskliutas
Merge branch 'master' into stateless_tree_api
b99177d
@saskliutas
Do not expose HierarchyNode
aea5ed8
@saskliutas
Cleanup pre-commit actions
2e39075
@saskliutas
Merge branch 'master' into stateless_tree_api
ad55c97
@saskliutas
Add ability to reload sub tree
01fdfc7
@saskliutas saskliutas linked an issue Mar 4, 2024 that may be closed by this pull request
Integrate hierarchy level filtering into test app #377
Closed
Base automatically changed from stateless_tree_api to master March 4, 2024 14:02
@saskliutas saskliutas marked this pull request as ready for review March 4, 2024 14:25
@saskliutas saskliutas requested a review from a team as a code owner March 4, 2024 14:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited

Benchmark

Benchmark suite Current: 17e186d Previous: 4bb0c41 Deviation Status
Initial Models Tree Load: Baytown.bim 336 ms 348 ms -3.4483% ✅
Full Models Tree Load: Baytown.bim 3092 ms 3134 ms -1.3401% ✅

This comment was automatically generated by workflow using github-action-benchmark.

@saskliutas saskliutas merged commit b596e07 into master Mar 5, 2024
9 checks passed
@saskliutas saskliutas deleted the stateless_tree_hierarchy_level_filtering branch March 5, 2024 14:22
@imodeljs-admin imodeljs-admin mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grigasp grigasp grigasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate hierarchy level filtering into test app
3 participants
@saskliutas @grigasp @JonasDov