Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree Widget: Test coverage #376

Closed
grigasp opened this issue Feb 28, 2023 · 8 comments · Fixed by #469, #482 or #486
Closed

Tree Widget: Test coverage #376

grigasp opened this issue Feb 28, 2023 · 8 comments · Fixed by #469, #482 or #486
Assignees
@simasjar
Labels
tree widget Tree widget or its components related issues
Milestone
Tree Widget: 1.0 ...

Comments

@grigasp
Copy link
Member

grigasp commented Feb 28, 2023 •
edited
Loading

This is sad:
Image

I hope for the 1.0 release we could at least get to 80%
@grigasp grigasp added the tree widget Tree widget or its components related issues label Feb 28, 2023
@grigasp grigasp added this to the Tree Widget: 1.0 release milestone Feb 28, 2023
@grigasp grigasp changed the title Tree Widget: E2E tests Tree Widget: Test coverage Apr 4, 2023
@saskliutas saskliutas self-assigned this Apr 25, 2023
@simasjar
Copy link
Contributor

As for today, test coverage looks like this:

Image

Because @saskliutas and I will be working together on this task, to avoid unnecessary work, I will be updating here what I will be working on. I will start with writing tests for category-tree, models-tree, and TreeHeader.tsx

@simasjar simasjar self-assigned this Apr 26, 2023
@grigasp
Copy link
Member Author

grigasp commented Apr 27, 2023

@saskliutas @simasjar, I'll add tests for imodel content tree.

@grigasp
Copy link
Member Author

grigasp commented Apr 27, 2023

Results after completing #451:
image

@saskliutas
Copy link
Member

I am working on tests for TreeHeader and SearchBox

@saskliutas
Copy link
Member

Working on tests for:
TreeFilteringState.ts
TreeWidgetComponent.tsx
TreeWidgetUiItemsProvider.tsx

@saskliutas
Copy link
Member

Results after completing #469
image

@saskliutas saskliutas linked a pull request May 10, 2023 that will close this issue
Tree Widget: Add more unit tests #469
Merged
@saskliutas saskliutas removed their assignment May 10, 2023
@grigasp
Copy link
Member Author

grigasp commented May 12, 2023

Results after completing #477
image

@simasjar simasjar mentioned this issue May 15, 2023
Merged
@simasjar
Copy link
Contributor

Results after completing #482
image

@grigasp grigasp mentioned this issue May 17, 2023
Merged
@grigasp grigasp linked a pull request May 17, 2023 that will close this issue
Tree Widget: Require 100% test coverage #486
Merged
@grigasp grigasp closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simasjar simasjar

Labels
tree widget Tree widget or its components related issues
Projects
None yet
Milestone
Tree Widget: 1.0 release
3 participants
@saskliutas @grigasp @simasjar