Tree Widget: Add more unit tests #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigasp
requested changes
May 8, 2023
Added localization |
grigasp
approved these changes
May 9, 2023
saskliutas
added a commit
that referenced
this pull request
Jun 6, 2023
* Tree Widget: API cleanup (#426) * Clean up internal API * rush change * Tree-Widget: Rework how trees are added to widget (#428) * Refactor the way how trees a provided to widget * rush change * Highlight in changelog that these are breaking changes * Update common/changes/@itwin/tree-widget-react/rework_additional_trees_handling_2023-04-14-14-58.json Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * Tree Widget: Add ability to conditionally show/hide trees in widget (#444) * Add ability to conditionally show trees in the widget * rush change * PR fixes * Tree-Widget: Fix invert button in categories tree (#434) * Fix invert button in categories tree * rush change * Pr comment fixes * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * more pr comment fixes * pr comment fixes * Apply suggestion from the code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes * pr comment fixes --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Tree widget: README improvements (#451) * Add `IModelContentTreeComponent` to be consistent with other trees * Improve README * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * rush update --------- Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Fix merge * Tree widget: API extractions (#467) * Start extracting `tree-widget-react` API * Release tags & some docs * fix docs * Tree Widget: Add more unit tests (#469) * Add tests for TreeHeader and SearchBox * Better cleanup TreeHeader tests * Use EmptyLocalization for tests * Add TreeWidgetComponent tests * Add TreeFilteringState tests * Add TreeWidgetUiItemsProvider tests * Add TreeWidget tests * Cleanup AutoSizer * Localize search component * extract-api * Models tree: Hierarchy configuration (#473) * Generate ruleset dynamically * Add a way to specialize class of geometric elements loaded into models tree * Tree widget: Make changelogs consistent (#474) * Tree widget: External sources tree (#476) * Add external sources tree component (`@alpha`) * rush change * 100% coverage * Tree Widget: Use type imports (#475) * Use type imports * rush change * Fix object spacing * Fix new imports * IModel content: 100% coverage (#477) * External sources tree: Add missing attributes `id` and `getLabel` (#478) * Tree widget: Setup linter to cleanup unused type imports (#479) * Tree widget: add tests for categories and models tree (#482) * add tests * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Pr comment fixes * lint fix * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes * Update packages/itwin/tree-widget/src/test/trees/CategoriesVisibilityUtils.test.ts Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes --------- Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Require 100% test coverage (#486) * Tree Widget: Keep child nodes state the same after parent node re-expands (#492) * Keep child nodes state the same after parent node re-expanding * rush change * fix comment * Models Tree: Disable root node colapsing (#490) * disable expansion toggle for root node * rush change * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes --------- Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Keep eye checkbox position static on horizontal scroll, make model and categories tree whitespace between eye checkbox and node label smalelr (#512) * Keep eye checkbox static on horizontal scroll and make whitespace between eye checkbox and node label smaller * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * pr comment and ui bug fixes * documentation fixes * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes * pr comment fixes * update changelogfile --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Tree widget: Use search box component from itwinui react (#515) * use itwinui searchbar * rush change * pr comment fixes * more pr comment fixes * Tree widget: Update dependencies (#519) * Update dependencies * Revive tests * Adjust styles * rush change * rush change * Tree widget: Update change types (#521) * Update change types * Update tree-widget version policy * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * Cleanup * Fix horizontal scrollbar hiding under other widgets * Update test-viewer deps * Update ExternalSources tree ruleset id * Use icon from `itwinui-icons-react` * Setup tree-widget for prerelease --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: simasjar <124659623+simasjar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for TreeHeader, SearchBox, TreeWidgetComponent, TreeWidget and TreeWidgetUiItemsProvider