Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree Widget: Update image links in README #450

Closed
Tracked by #447
grigasp opened this issue Apr 27, 2023 · 1 comment
Closed
Tracked by #447

Tree Widget: Update image links in README #450

grigasp opened this issue Apr 27, 2023 · 1 comment
Assignees
@saskliutas
Labels
tree widget Tree widget or its components related issues
Milestone
Tree Widget: 1.0 ...

Comments

@grigasp
Copy link
Member

grigasp commented Apr 27, 2023

README.md references images using a relative path, but the images aren't packed, so they won't show up in npmjs.com. After merging to master we could change those relative links to appropriate links of images hosted on github in this repository.
@grigasp grigasp added the tree widget Tree widget or its components related issues label Apr 27, 2023
@grigasp grigasp added this to the Tree Widget: 1.0 release milestone Apr 27, 2023
@grigasp grigasp mentioned this issue Apr 27, 2023
Merged
@grigasp grigasp mentioned this issue May 24, 2023
Closed
@grigasp grigasp mentioned this issue Jun 2, 2023
Merged
@grigasp
Copy link
Member Author

grigasp commented Jun 6, 2023

Turns out npm is able to resolve the images using repository information in package.json and relative links. Closing the issue.

@grigasp grigasp closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saskliutas saskliutas

Labels
tree widget Tree widget or its components related issues
Projects
None yet
Milestone
Tree Widget: 1.0 release
Development

No branches or pull requests
2 participants
@saskliutas @grigasp