Tree widget 1.0 #522

saskliutas · 2023-06-01T11:20:37Z

No description provided.

* Clean up internal API * rush change

* Refactor the way how trees a provided to widget * rush change * Highlight in changelog that these are breaking changes * Update common/changes/@itwin/tree-widget-react/rework_additional_trees_handling_2023-04-14-14-58.json Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

…444) * Add ability to conditionally show trees in the widget * rush change * PR fixes

* Fix invert button in categories tree * rush change * Pr comment fixes * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * more pr comment fixes * pr comment fixes * Apply suggestion from the code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes * pr comment fixes --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

* Add `IModelContentTreeComponent` to be consistent with other trees * Improve README * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * rush update --------- Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

* Start extracting `tree-widget-react` API * Release tags & some docs * fix docs

* Add tests for TreeHeader and SearchBox * Better cleanup TreeHeader tests * Use EmptyLocalization for tests * Add TreeWidgetComponent tests * Add TreeFilteringState tests * Add TreeWidgetUiItemsProvider tests * Add TreeWidget tests * Cleanup AutoSizer * Localize search component * extract-api

* Generate ruleset dynamically * Add a way to specialize class of geometric elements loaded into models tree

* Add external sources tree component (`@alpha`) * rush change * 100% coverage

* Use type imports * rush change * Fix object spacing * Fix new imports

* add tests * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * Pr comment fixes * lint fix * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes * Update packages/itwin/tree-widget/src/test/trees/CategoriesVisibilityUtils.test.ts Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes --------- Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

…ands (#492) * Keep child nodes state the same after parent node re-expanding * rush change * fix comment

* disable expansion toggle for root node * rush change * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes --------- Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

…d categories tree whitespace between eye checkbox and node label smalelr (#512) * Keep eye checkbox static on horizontal scroll and make whitespace between eye checkbox and node label smaller * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * pr comment and ui bug fixes * documentation fixes * Apply suggestions from code review Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> * pr comment fixes * pr comment fixes * update changelogfile --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>

* use itwinui searchbar * rush change * pr comment fixes * more pr comment fixes

* Update dependencies * Revive tests * Adjust styles * rush change * rush change

* Update change types * Update tree-widget version policy * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

grigasp · 2023-06-01T11:59:35Z

@aruniverse, please have a look

packages/itwin/tree-widget/package.json

packages/itwin/tree-widget/src/components/TreeWidgetUiItemsProvider.tsx

packages/itwin/tree-widget/src/components/trees/external-sources-tree/ExternalSources.json

packages/itwin/tree-widget/README.md

apps/test-viewer/package.json

apps/test-viewer/src/components/Viewer.tsx

aruniverse

apologies its not 1 massive review but rather multile one off ones.

changes look fine, some small nit picks.

did you want to publish a pre-release with all these changes or just go straight to 1.0?

grigasp · 2023-06-02T09:00:45Z

apologies its not 1 massive review but rather multile one off ones.

changes look fine, some small nit picks.

did you want to publish a pre-release with all these changes or just go straight to 1.0?

Thanks for looking at this. We were thinking about going straight to 1.0, but doing a pre-release before that makes sense, IMO. @saskliutas what do you think?

saskliutas · 2023-06-05T11:40:03Z

apologies its not 1 massive review but rather multile one off ones.
changes look fine, some small nit picks.
did you want to publish a pre-release with all these changes or just go straight to 1.0?

Thanks for looking at this. We were thinking about going straight to 1.0, but doing a pre-release before that makes sense, IMO. @saskliutas what do you think?

I think it makes sense to do a pre-release as there are a lot of changes. @aruniverse can your take a look at 2ba7df5?

common/config/rush/version-policies.json

aruniverse

lgtm

saskliutas and others added 26 commits April 14, 2023 09:48

Tree Widget: API cleanup (#426)

595b7d2

* Clean up internal API * rush change

Tree Widget: Add ability to conditionally show/hide trees in widget (#…

ab252c4

…444) * Add ability to conditionally show trees in the widget * rush change * PR fixes

Merge branch 'master' into tree_widget_1.0

ea34328

Fix merge

6e4d473

Tree widget: API extractions (#467)

7d018d5

* Start extracting `tree-widget-react` API * Release tags & some docs * fix docs

Models tree: Hierarchy configuration (#473)

922c132

* Generate ruleset dynamically * Add a way to specialize class of geometric elements loaded into models tree

Tree widget: Make changelogs consistent (#474)

fbe48a0

Tree widget: External sources tree (#476)

2bebd8c

* Add external sources tree component (`@alpha`) * rush change * 100% coverage

Tree Widget: Use type imports (#475)

8014653

* Use type imports * rush change * Fix object spacing * Fix new imports

IModel content: 100% coverage (#477)

e45fa7c

External sources tree: Add missing attributes id and getLabel (#478)

ceae7d7

Tree widget: Setup linter to cleanup unused type imports (#479)

c6a821d

Require 100% test coverage (#486)

dfcff15

Tree Widget: Keep child nodes state the same after parent node re-exp…

0ed4a6e

…ands (#492) * Keep child nodes state the same after parent node re-expanding * rush change * fix comment

Tree widget: Use search box component from itwinui react (#515)

ca683b6

* use itwinui searchbar * rush change * pr comment fixes * more pr comment fixes

Merge branch 'master' into tree_widget_1.0

96592bd

Tree widget: Update dependencies (#519)

e177734

* Update dependencies * Revive tests * Adjust styles * rush change * rush change

Tree widget: Update change types (#521)

d38405f

* Update change types * Update tree-widget version policy * Apply suggestions from code review Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> --------- Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

Cleanup

79f72d3

saskliutas requested a review from grigasp June 1, 2023 11:20

saskliutas requested review from a team and DanishMehmood-bit as code owners June 1, 2023 11:20

saskliutas mentioned this pull request Jun 1, 2023

Tree Widget: Release the package #447

Closed

grigasp approved these changes Jun 1, 2023

View reviewed changes

Fix horizontal scrollbar hiding under other widgets

af318a4