Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree widget: Telemetry enhancements #979

Closed
grigasp opened this issue Jul 2, 2024 · 0 comments · Fixed by iTwin/presentation#661 or #988
Closed

Tree widget: Telemetry enhancements #979

grigasp opened this issue Jul 2, 2024 · 0 comments · Fixed by iTwin/presentation#661 or #988
Assignees
Labels
enhancement New feature or request tree widget Tree widget or its components related issues

Comments

@grigasp
Copy link
Member

grigasp commented Jul 2, 2024

  1. Need some way to know about errors happening in the widget. Maybe we could report them as "features", e.g. error-timeout, error-unknown?..

  2. From performance telemetry numbers it's not clear if the value is for a successful result or an error result. For the latter, I even think we should distinguish timeouts and other kinds of errors:

    • for successful results, return the duration as we do at the moment,
    • for timeout results, return a constant large number, maybe MAX_INTEGER,
    • for non-timeout error results, don't report performance telemetry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tree widget Tree widget or its components related issues
Projects
None yet
2 participants