-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS0103: open a .osim file and load its elements to the visualizer. #3
Comments
Note: I suggest doing this in two phases but feel free to use vtk directly if this is easier.
|
|
@idhamari
how do you think we should procced , and here is a screenshot of OpenSimQt using the server of |
the source code is available, so probably we can either:
For now, I suggest to use the QtWebEngine solution if the above solutions take time, I will try to test it tomorrow and provide feedback. I have some students who may work on the |
@yasseerr You may start working on the next tasks as they are independent and they should not take time. |
@idhamari totaly agree building a visualizer using Qt3D opengl will be inspired from the default visualiser by going over SimTK documentation https://stanford.edu/~dembia/simbody_taskspace/html/classSimTK_1_1Visualizer.html |
probably we can build a shared visualizer library by modifying the simbody visualizer CMakeLists.txt , you can also ask about this in the simbody forum, check first if there are related questions. It seems QtCreator can not recognize QWebEngineView widget, I get this error: mainwindow.cpp:-1: error: undefined reference to `QWebEngineView::QWebEngineView(QWidget*)' Maybe this is an error related to Qt version, what version of are you using. Mine is Qt5.9.5. I could be able to run the Qt web examples i.e. webengine and webview but they used .pro not CMake, they also uses QML. So Maybe the problem is related to CMake or QML. |
Nice! the server is created when you run the netbeans app (just for demonstration) |
Yes, it works now, thanks for the info. |
As I understood:
Next Todos: Creating vsSimbodyVisualizer alongside the current simebody-visualizer.
|
please use our simbody branch: https://github.com/VisSimKoblenz/simbody/tree/vsSimbodyVisualizer You may also change the link in opensim-core dependancy Cmake to point to this link as well. |
@idhamari understood ! |
Urgent Before things get out of control as we are getting more and more files, please organize the naming of the current files in a standard way:
This will ensure readability and solve compatibility in Linux. |
A useful VTK book is added. |
@idhamari thanks for the suggestion! |
This sound great
If in the future you have such a problem please let me know. I could suggest we ignore the vtp file because it is only one format and can be converted to another format when needed e.g. stl I am looking forward to testing the next working version version. |
good to know, but the problem was about getting the system to load the meshes from the bodies independent from the mesh format, its about tweaking the params and calling the right functions |
@idhamari hi! |
@yasseerr Not sure, which model are you using? they look like markers. |
Notice that some model elements are visualized by opengl e.g markers, muscles and sometimes bodies. This means the mesh is generated programmatically not input from a file. |
Looks great, well done! I will test it soon and provide a feedback. |
thank you, but it is not ready for testing and if you want to test it change the path in vsMainWindow.cpp to your geometry folder |
Good to know! I suggest:
|
ok, that will help to not set the path at each installation |
I also finds a few bugs related to compatibility with Linux. Please check them and consider them in your next commit (you can download the master branch as it is equivalent to this commit. |
@yasseerr there is something important to openGL. Do you think it is possible to use an older VTK version that supports an older opengl? this will give a big advantage: our interface can run on older computers in addition to virtualbox. |
what does the linux error say? |
It is related to the file and class names you missed. Also sometimes you are using the class name when it is not needed. You can compare your branch with the master branch and check what changed. For now, no need to worry about this. Please continue using the current version. |
Here is an example of the error: in vsMainwindow.cpp you used vsMainWindow::vsMainWindow(QWidget *parent) so changing the filename vsMainwindow.cpp to vsMainWindow.cpp fix the problem There are some other similar problems so please use the fixed code from the master in your branch. |
We will continue using the new openGL for now as the hardware is getting better and the one we use is from last year. I also think virtualbox may updated their tool as well to support new openGL |
hopefully. |
I just tested it and it looks very good. I had a problem in my system related to OpenGL but i fixed it. It appears when secure boot is enabled it disable unsigned nvidia driver. This can be solved by disabling secure boot or signing nvidia driver. For the big joints point, you can change their size in the program so they appear smaller than the others. In the future, we can give them a different shape so they can be recognized easily. There is still something missing: the two-way selection e.g. when you select something in the visualizer window, it should be selected in the navigator and vice versa. This is not part of the simbody-visualizer so you can find the implementation in the java interface. |
I will wait until you use and test the updating in the master branch as it fixe a few linux bugs.
Ok. When everything is done we will have a skype meeting to discuss the progress and close this task. |
@idhamari Hello! |
@yasseerr excellent.
Well done! there are still two errors:
This can be fixed by using:
Please consider the same practice in future code.
This can be fixed by changing two filenames(notice the first letter in "Force"):
|
Then merge with the master branch and close this issue. |
errors fixed at commit ffbd6ac |
This is one of the main tasks and it may take a longer time.
The text was updated successfully, but these errors were encountered: