Skip to content

Commit

Permalink
Remove some todo's
Browse files Browse the repository at this point in the history
  • Loading branch information
iafisher committed Feb 12, 2019
1 parent 91b54fb commit 3573439
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
2 changes: 0 additions & 2 deletions hera/checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,6 @@ def convert_ops(
if isinstance(op, RelativeBranch) and op.tokens[0].type == Token.SYMBOL:
target = symbol_table[op.args[0]]
jump = target - pc
# TODO: Will this work? I think pc takes data statements into account here
# erroneously.
if jump < -128 or jump >= 128:
messages.err("label is too far for a relative branch", loc=op.tokens[0])
else:
Expand Down
5 changes: 1 addition & 4 deletions test/test_from_manual.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
"""All test programs in this module taken from the official HERA manual.
TODO: Check these results against HERA-C.
"""
"""All test programs in this module taken from the official HERA manual."""
from hera.data import DEFAULT_DATA_START
from hera.utils import to_u16
from .utils import execute_program_helper
Expand Down
1 change: 0 additions & 1 deletion test/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ def test_function_call_program(capsys):


def test_fibonacci_program(capsys):
# TODO: Does this really belong in the simple test suite?
program = """\
/*
Expand Down

0 comments on commit 3573439

Please sign in to comment.