Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a builder like api for binary benchmarks in addition to the macro api #3

Closed
Joining7943 opened this issue Aug 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Joining7943
Copy link
Collaborator

This issue came up in #2

Binary benchmarks can be currently setup with the main macro. The macro api is short and concise but macros are a little bit uncomfortable to work with, so a builder like api could provide a more convenient but also more verbose method to setup binary benchmarks.

@Joining7943 Joining7943 added the enhancement New feature or request label Aug 7, 2023
@Joining7943
Copy link
Collaborator Author

Hi @epage. Have you tried the new version 0.5.0 of iai-callgrind with #2 merged? Are you still interested in using iai-callgrind and having a builder like api?

@epage
Copy link

epage commented Aug 17, 2023

I am still interested in having a solution for this need and consider a criterion-like API a hard requirement. It doesn't have to be a 1:1 and doesn't have to all exist from the beginning but putting everything in a single macro and trying to express the relevant needs is not a sustainable solution for adoption in my mind.

@Joining7943
Copy link
Collaborator Author

Ok, great! So, I haven't lost you on the way. Sorry, that it took some time but I found this change was too big to do it in a single step. I hope you find what you were looking for.

I finished the builder like api (so far) and it provides the same functionality (and more) of the macro api. You'll see the new builder api has some similarities to the criterion api. Everything's documented in the README and in the library documentation. If you're missing something, feel free to comment or open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants