Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip Tab 2.7 not working as expected with Tab-less 0.5.2 #13

Closed
grahamperrin opened this issue Sep 25, 2018 · 4 comments
Closed

Tip Tab 2.7 not working as expected with Tab-less 0.5.2 #13

grahamperrin opened this issue Sep 25, 2018 · 4 comments

Comments

@grahamperrin
Copy link

https://addons.mozilla.org/addon/tip-tab/

With a preference for Tip Tab to not open in a new window, Tab-less does (as expected) open the tab of Tip Tab in a new window.

However: if the window of Tip Tab is left open, then (in any other window) a click on the Tip Tab icon will bring to front:

  • the window in which the Tip Tab tab originated

– not the Tip Tab window.

Can you imagine a workaround for this issue on the Tab-less side? Or would it be something for the developer of Tip Tab to consider, as an enhancement?

Environment

Firefox 62.0 (64-bit) on FreeBSD-CURRENT.


Side note:

– and whilst that bug is not fixed, the userChrome.css workaround at https://superuser.com/a/1268734.

@iainbeeston
Copy link
Owner

Can I just repeat what you said in my own words, to see if I've understood the issue correctly?

With tab-less and tip tab working together, when you press the tip tab button in the address bar (from window A), it opens tip tab in a new window (let's call that window B) instead of in a new tab. Then if you don't close the tip tab window, and press the tip tab button again (let's say from a new window, window C), the tip tab window (window B) should come to the front, but instead the window that you first pressed the tip tab button on (window A) comes to the front?

Is that correct?

@grahamperrin
Copy link
Author

Correct, exactly.

@iainbeeston
Copy link
Owner

I must admit, it sounds like an issue with Tip Tab: Tab-Less correctly opens Tip Tab in a new window the first time, but when you click Tip Tab again, Tab-Less wouldn't get involved. I suspect that Tip Tab records which window it was first opened in, and re-focuses that when you click the Tip Tab button. But in this situation Tip Tab has been pulled off into a new window, and so the wrong window is focused.

You could test this theory by:

  1. Disabling Tab-Less
  2. Press the Tip Tab button to open Tip Tab
  3. Drag the Tip Tab tab out of it's window, so it's in a new Window by itself
  4. Focus on another window or continue browsing
  5. Press the Tip Tab button again

If I'm correct, Tip Tab will now focus on the window that opened Tip Tab tab the first time, not the new Tip Tap window, and it's a bug with Tip Tab.

@grahamperrin
Copy link
Author

… If I'm correct, …

True. Tested with slightly more recent Tip Tab 2.8 and Firefox 62.0.2 (64-bit).

It's edge case (more than anything, I was curious to see how the two extensions might interact) … I might draw it to the attention of the developer in due course. A few other things to deal with first :-)

Thanks for your time and insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants