#58 - Extracting delay to application.properties

iakunin · May 4, 2020 · 3946e03 · 3946e03
1 parent 9b0c637
commit 3946e03
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 6 deletions.
diff --git a/src/main/java/dev/iakunin/codexiabot/github/cron/stat/LinesOfCode.java b/src/main/java/dev/iakunin/codexiabot/github/cron/stat/LinesOfCode.java
@@ -5,16 +5,14 @@
 import dev.iakunin.codexiabot.github.repository.GithubRepoStatRepository;
 import dev.iakunin.codexiabot.github.sdk.CodetabsClient;
 import java.util.Objects;
-import lombok.AllArgsConstructor;
 import lombok.SneakyThrows;
 import lombok.extern.slf4j.Slf4j;
-import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.http.HttpStatus;
 import org.springframework.stereotype.Component;
 
 @Component
 @Slf4j
-@AllArgsConstructor(onConstructor_={@Autowired})
 public final class LinesOfCode implements Runnable {
 
     private final GithubRepoRepository githubRepoRepository;
@@ -23,6 +21,20 @@ public final class LinesOfCode implements Runnable {
 
     private final CodetabsClient codetabsClient;
 
+    private final Integer delay;
+
+    public LinesOfCode(
+        GithubRepoRepository githubRepoRepository,
+        GithubRepoStatRepository githubRepoStatRepository,
+        CodetabsClient codetabsClient,
+        @Value("${app.cron.github.stat.lines-of-code.delay}") Integer delay
+    ) {
+        this.githubRepoRepository = githubRepoRepository;
+        this.githubRepoStatRepository = githubRepoStatRepository;
+        this.codetabsClient = codetabsClient;
+        this.delay = delay;
+    }
+
     public void run() {
         this.githubRepoRepository.findAllWithoutLinesOfCode().forEach(
             githubRepo -> {
@@ -50,8 +62,7 @@ public void run() {
                     }
                 } finally {
                     log.debug("Sleeping...");
-                    // @todo #58 configure this timeout for tests
-                    sleep(5000);
+                    sleep(this.delay);
                 }
             }
         );

diff --git a/src/main/resources/META-INF/spring-configuration-metadata.json b/src/main/resources/META-INF/spring-configuration-metadata.json
@@ -159,6 +159,11 @@
       "name": "app.codetabs.base-url",
       "type": "java.lang.String",
       "description": "Base url of Codetabs."
+    },
+    {
+      "name": "app.cron.github.stat.lines-of-code.delay",
+      "type": "java.lang.Integer",
+      "description": "Delay for github.stat.lines-of-code cron."
     }
   ]
 }
diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties
@@ -44,3 +44,5 @@ app.reddit.client-id=<insert-your-reddit-client-id-here>
 app.reddit.client-secret=<insert-your-reddit-client-secret-here>
 
 app.codetabs.base-url=https://api.codetabs.com/v1/
+
+app.cron.github.stat.lines-of-code.delay=5000
diff --git a/src/test/java/dev/iakunin/codexiabot/github/cron/stat/LinesOfCodeIntegrationTest.java b/src/test/java/dev/iakunin/codexiabot/github/cron/stat/LinesOfCodeIntegrationTest.java
@@ -111,7 +111,8 @@ static class Initializer implements ApplicationContextInitializer<ConfigurableAp
         @Override
         public void initialize(ConfigurableApplicationContext applicationContext) {
             TestPropertyValues.of(
-                "app.codetabs.base-url=" + WireMockServer.getInstance().baseUrl()
+                "app.codetabs.base-url=" + WireMockServer.getInstance().baseUrl(),
+                "app.cron.github.stat.lines-of-code.delay=0"
             ).applyTo(applicationContext.getEnvironment());
         }
     }