(#74) Merge pull request #166 from iakunin/74

#6 74 - AllItemsIntegrationTest

src/main/java/dev/iakunin/codexiabot/hackernews/cron/GapsFiller.java

@@ -23,6 +23,8 @@ public class GapsFiller implements Runnable {
 
     private final Writer writer;
 
+    // @todo #74 GapsFiller: get rid of this @Transactional spike
+    //  to do so it's necessary to get rid of Stream<> in repository
     @Transactional // https://stackoverflow.com/a/40593697/3456163
     public void run() {
         this.repository

src/main/java/dev/iakunin/codexiabot/hackernews/cron/healthcheck/AllItems.java

@@ -20,6 +20,8 @@ public class AllItems implements Runnable {
 
     private final HackernewsModule hackernews;
 
+    // @todo #74 AllItems: get rid of this @Transactional spike
+    //  to do so it's necessary to get rid of Stream<> in repository
     @Transactional // https://stackoverflow.com/a/40593697/3456163
     public void run() {
         try (Stream<GithubRepoSource> sources = this.github.findAllRepoSources(Source.HACKERNEWS)) {

src/main/java/dev/iakunin/codexiabot/hackernews/sdk/HackernewsClient.java

@@ -10,7 +10,7 @@
 
 @FeignClient(
     name = "hackernewsClient",
-    url = "https://hacker-news.firebaseio.com/v0/",
+    url = "${app.hackernews.base-url}",
     configuration = GeneralClientConfiguration.class
 )
 public interface HackernewsClient {

src/main/resources/META-INF/spring-configuration-metadata.json

@@ -165,6 +165,11 @@
       "type": "java.lang.String",
       "description": "Base url of Codetabs."
     },
+    {
+      "name": "app.hackernews.base-url",
+      "type": "java.lang.String",
+      "description": "Base url of Hackernews."
+    },
     {
       "name": "app.github.service.lines-of-code.delay",
       "type": "java.lang.Integer",

src/main/resources/application.properties

@@ -44,5 +44,6 @@ app.reddit.client-id=<insert-your-reddit-client-id-here>
 app.reddit.client-secret=<insert-your-reddit-client-secret-here>
 
 app.codetabs.base-url=https://api.codetabs.com/v1/
+app.hackernews.base-url=https://hacker-news.firebaseio.com/v0/
 
 app.github.service.lines-of-code.delay=5000

src/test/java/dev/iakunin/codexiabot/hackernews/cron/healthcheck/AllItemsIntegrationTest.java

@@ -1,13 +1,99 @@
 package dev.iakunin.codexiabot.hackernews.cron.healthcheck;
 
+import com.github.database.rider.core.api.dataset.DataSet;
+import com.github.database.rider.core.api.dataset.ExpectedDataSet;
 import dev.iakunin.codexiabot.AbstractIntegrationTest;
+import dev.iakunin.codexiabot.util.WireMockServer;
+import dev.iakunin.codexiabot.util.wiremock.Response;
+import dev.iakunin.codexiabot.util.wiremock.Stub;
+import org.cactoos.io.ResourceOf;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.util.TestPropertyValues;
+import org.springframework.context.ApplicationContextInitializer;
+import org.springframework.context.ConfigurableApplicationContext;
+import org.springframework.http.HttpStatus;
+import org.springframework.test.context.ContextConfiguration;
 
+@ContextConfiguration(initializers = AllItemsIntegrationTest.Initializer.class)
 public class AllItemsIntegrationTest extends AbstractIntegrationTest {
 
     @Autowired
     private AllItems allItems;
 
-    // @todo #66 Implement AllItemsIntegrationTest
+    @Test
+    @DataSet(
+        value = "db-rider/hackernews/cron/health-check/all-items/initial/emptyDatabase.yml",
+        cleanBefore = true, cleanAfter = true
+    )
+    @ExpectedDataSet("db-rider/hackernews/cron/health-check/all-items/expected/emptyDatabase.yml")
+    public void emptyDatabase() {
+        allItems.run();
+    }
 
+    @Test
+    @DataSet(
+        value = "db-rider/hackernews/cron/health-check/all-items/initial/oneActiveItem.yml",
+        cleanBefore = true, cleanAfter = true
+    )
+    @ExpectedDataSet("db-rider/hackernews/cron/health-check/all-items/expected/oneActiveItem.yml")
+    public void oneActiveItem() {
+        WireMockServer.stub(
+            new Stub(
+                "/item/2222.json",
+                new ResourceOf("wiremock/hackernews/cron/health-check/all-items/oneActiveItem.json")
+            )
+        );
+
+        allItems.run();
+    }
+
+    @Test
+    @DataSet(
+        value = "db-rider/hackernews/cron/health-check/all-items/initial/oneDeletedItem.yml",
+        cleanBefore = true, cleanAfter = true
+    )
+    @ExpectedDataSet("db-rider/hackernews/cron/health-check/all-items/expected/oneDeletedItem.yml")
+    public void oneDeletedItem() {
+        WireMockServer.stub(
+            new Stub(
+                "/item/2222.json",
+                new ResourceOf("wiremock/hackernews/cron/health-check/all-items/oneDeletedItem.json")
+            )
+        );
+
+        allItems.run();
+    }
+
+    @Test
+    @DataSet(
+        value = "db-rider/hackernews/cron/health-check/all-items/initial/hackernewsException.yml",
+        cleanBefore = true, cleanAfter = true
+    )
+    @ExpectedDataSet("db-rider/hackernews/cron/health-check/all-items/expected/hackernewsException.yml")
+    public void hackernewsException() {
+        WireMockServer.stub(
+            new Stub(
+                "/item/2222.json",
+                new Response(HttpStatus.INTERNAL_SERVER_ERROR.value())
+            )
+        );
+
+        allItems.run();
+    }
+
+    @AfterEach
+    void after() {
+        WireMockServer.getInstance().resetAll();
+    }
+
+    static class Initializer implements ApplicationContextInitializer<ConfigurableApplicationContext> {
+        @Override
+        public void initialize(ConfigurableApplicationContext applicationContext) {
+            TestPropertyValues.of(
+                "app.hackernews.base-url=" + WireMockServer.getInstance().baseUrl()
+            ).applyTo(applicationContext.getEnvironment());
+        }
+    }
 }

src/test/resources/db-rider/hackernews/cron/health-check/all-items/expected/emptyDatabase.yml

@@ -0,0 +1,3 @@
+github_repo_source: []
+
+hackernews_item: []

src/test/resources/db-rider/hackernews/cron/health-check/all-items/expected/hackernewsException.yml

@@ -0,0 +1,15 @@
+github_repo_source:
+    -
+        github_repo_id: 1
+        source: "HACKERNEWS"
+        external_id: "2222"
+
+hackernews_item:
+    -
+        external_id: 2222
+        type: story
+        by: smartmic
+        title: Title for casbin
+        url: https://github.com/casbin/casbin
+        time: 2020-02-14 18:43:33
+        deleted: false

src/test/resources/db-rider/hackernews/cron/health-check/all-items/expected/oneActiveItem.yml

@@ -0,0 +1,15 @@
+github_repo_source:
+    -
+        github_repo_id: 1
+        source: "HACKERNEWS"
+        external_id: "2222"
+
+hackernews_item:
+    -
+        external_id: 2222
+        type: story
+        by: smartmic
+        title: Title for casbin
+        url: https://github.com/casbin/casbin
+        time: 2020-02-14 18:43:33
+        deleted: false

src/test/resources/db-rider/hackernews/cron/health-check/all-items/expected/oneDeletedItem.yml

@@ -0,0 +1,16 @@
+github_repo_source:
+    -
+        github_repo_id: 1
+        source: "HACKERNEWS"
+        external_id: "2222"
+        deleted_at: regex:^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d{1,6}$
+
+hackernews_item:
+    -
+        external_id: 2222
+        type: story
+        by: smartmic
+        title: Title for casbin
+        url: https://github.com/casbin/casbin
+        time: 2009-01-15 05:56:02
+        deleted: true

src/test/resources/db-rider/hackernews/cron/health-check/all-items/initial/emptyDatabase.yml

@@ -0,0 +1,5 @@
+github_repo: []
+
+github_repo_source: []
+
+hackernews_item: []

src/test/resources/db-rider/hackernews/cron/health-check/all-items/initial/hackernewsException.yml

@@ -0,0 +1,26 @@
+github_repo:
+    -
+        id: 1
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 202275988
+        full_name: casbin/casbin
+        html_url: https://github.com/casbin/casbin
+        repo_created_at: 2019-08-14 04:42:36
+
+github_repo_source:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        source: "HACKERNEWS"
+        external_id: "2222"
+
+hackernews_item:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 2222
+        type: story
+        by: smartmic
+        title: Title for casbin
+        url: https://github.com/casbin/casbin
+        time: 2020-02-14 18:43:33
+        deleted: false

src/test/resources/db-rider/hackernews/cron/health-check/all-items/initial/oneActiveItem.yml

@@ -0,0 +1,26 @@
+github_repo:
+    -
+        id: 1
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 202275988
+        full_name: casbin/casbin
+        html_url: https://github.com/casbin/casbin
+        repo_created_at: 2019-08-14 04:42:36
+
+github_repo_source:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        source: "HACKERNEWS"
+        external_id: "2222"
+
+hackernews_item:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 2222
+        type: story
+        by: smartmic
+        title: Title for casbin
+        url: https://github.com/casbin/casbin
+        time: 2020-02-14 18:43:33
+        deleted: false

src/test/resources/db-rider/hackernews/cron/health-check/all-items/initial/oneDeletedItem.yml

@@ -0,0 +1,26 @@
+github_repo:
+    -
+        id: 1
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 202275988
+        full_name: casbin/casbin
+        html_url: https://github.com/casbin/casbin
+        repo_created_at: 2019-08-14 04:42:36
+
+github_repo_source:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        github_repo_id: 1
+        source: "HACKERNEWS"
+        external_id: "2222"
+
+hackernews_item:
+    -
+        uuid: "groovy: UUID.randomUUID().toString()"
+        external_id: 2222
+        type: story
+        by: smartmic
+        title: Title for casbin
+        url: https://github.com/casbin/casbin
+        time: 2020-02-14 18:43:33
+        deleted: false

src/test/resources/wiremock/hackernews/cron/health-check/all-items/oneActiveItem.json

@@ -0,0 +1,11 @@
+{
+  "by": "smartmic",
+  "id": 2222,
+  "text": "Some awesome text.",
+  "title": "Title for casbin",
+  "url": "https://github.com/casbin/casbin",
+  "time": 1231998962,
+  "type": "story",
+  "descendants": 0,
+  "score": 2
+}

src/test/resources/wiremock/hackernews/cron/health-check/all-items/oneDeletedItem.json

@@ -0,0 +1,12 @@
+{
+  "by": "smartmic",
+  "id": 2222,
+  "text": "Some awesome text.",
+  "title": "Title for casbin",
+  "url": "https://github.com/casbin/casbin",
+  "time": 1231998962,
+  "type": "story",
+  "descendants": 0,
+  "score": 2,
+  "deleted": true
+}