Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments need to be limited in text length #34

Closed
alevchuk opened this issue Jul 12, 2011 · 5 comments
Closed

Comments need to be limited in text length #34

alevchuk opened this issue Jul 12, 2011 · 5 comments

Comments

@alevchuk
Copy link
Contributor

I was able to post kilobytes of text as comment here: http://biostar.bx.psu.edu/question/show/72/

There should be a server-side limit as well as a JS client side notifier.

@ialbert
Copy link
Owner

ialbert commented Nov 29, 2011

I want to change a bit how comments work in that they should be allowed to be longer and also contain markdown, comments will soon be threaded and resemble a forum.

@alevchuk
Copy link
Contributor Author

Can I just submit a mini pull request closing this issue with a comment limit at 2000 characters?

@alevchuk
Copy link
Contributor Author

After some more thought, deleted my earlier opinion about threaded comments.

@ialbert
Copy link
Owner

ialbert commented Nov 30, 2011

We do need to limit lengths in various ways.

First the form field needs to validate size and if it is too large communicate that to user, in the second step the database will reject post sizes above the limit.

@ialbert
Copy link
Owner

ialbert commented Dec 15, 2011

there is now a limit of a few thousand characters - it will be tunable it to whatever one needs

@ialbert ialbert closed this as completed Dec 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants