Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Malformed entries #103

Closed
2 of 20 tasks
nicolaasjan opened this issue Nov 12, 2022 · 2 comments
Closed
2 of 20 tasks

[bug] Malformed entries #103

nicolaasjan opened this issue Nov 12, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@nicolaasjan
Copy link

What extention/adblocker/firewall do you have?

  • AdBlock Plus
  • AdGuard (browser)
  • uBlock Origin
  • Hosts file

What OS/browser do you have (optional)

What list(s) are you using?

  • Porn.txt
  • Antirickroll
  • Antimalware
  • Other (explain)

What other lists do you have (optional - helps me find the problem)

What is the issue?

  • Is this a feature request?
  • Is this site breakage?
  • Did you test in Firefox
  • Does this problem still occur when the website is force reloaded? (Control-Shift-R for most browsers on Linux, Cmd-Shift-R for MacOS)
  • Did you test:
    • In another browser
    • In an modified browser profile
    • On another device
    • When disabling all other lists except the defaults
    • When disabling all other extentions
    • On the latest version for your OS, browser, and adblocker
    • Using an up-to-date version of uBlock Origin or AdGuard

If it is site breakage, how is the site broken:

Did you try updating your lists? This could fix the problem.

In ./Alternative list formats/antimalware_pure_hosts.txt there are the following 2 entries:

0.0.0.0 ||randy_sahotsky2528.shopchizarma.xyz^
0.0.0.0 ||alhizaperfumes.co

I think they should be:

0.0.0.0 randy_sahotsky2528.shopchizarma.xyz
0.0.0.0 alhizaperfumes.co
@nicolaasjan nicolaasjan added the bug Something isn't working label Nov 12, 2022
iam-py-test added a commit that referenced this issue Nov 12, 2022
@iam-py-test
Copy link
Owner

The ||alhizaperfumes.co one is an easy fix, but the other one has me confused. I will try to address it later today.

iam-py-test added a commit that referenced this issue Nov 12, 2022
@iam-py-test
Copy link
Owner

Thank you for reporting this. It seems the issue was that the punycode encoder I was using doesn't like underscores, causing the code to fallback on some weird old code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants