Support classification with linear models #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamDecode
force-pushed
the
decode/glm-classifiers
branch
from
1ccd789
to
9650e25
Compare
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 559 624 +65
=========================================
+ Hits 559 624 +65
Continue to review full report at Codecov.
|
iamDecode
force-pushed
the
decode/glm-classifiers
branch
from
9650e25
to
062da46
Compare
This corresponds to the LogisticRegression and RidgeClassifier classes from sklearn.
iamDecode
force-pushed
the
decode/glm-classifiers
branch
from
062da46
to
04b9993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only linear regression was supported, but the step towards supporting logistic regression is trivial. This PR implements this.
There is unfortunately a bit of code duplication (
PMMLLinearModel/PMMLLinearClassifierandPMMLGeneralizedLinearRegressor/PMMLGeneralizedLinearClassifier). IdeallyPMMLLinearModelshould be a generic class that can be eitherPMMLBaseRegressororPMMLBaseClassifier. However, I was not able to usetyping.Genericand also callsuper.__init__()on the generic class. This should be revisited later.