Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file objects containing bytes (like BytesIO) #53

Merged
merged 1 commit into from Nov 22, 2023

Conversation

iamDecode
Copy link
Owner

Previously, byte-containing files were not supported, but such file objects are less error prone and supported by the eTree XML parser. This avoids the necessity of reading all contents as bytes, converting it to string, then passing it as StringIO, which is unnecessary loss of performance.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4bed07) 99.13% compared to head (237c1f2) 99.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   99.13%   99.45%   +0.32%     
==========================================
  Files          24       24              
  Lines        1266     1278      +12     
==========================================
+ Hits         1255     1271      +16     
+ Misses         11        7       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamDecode iamDecode merged commit 7cc4149 into master Nov 22, 2023
18 checks passed
@iamDecode iamDecode deleted the decode/support-bytes branch November 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant