Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract babel config into a .babelrc file #5

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

psevcenco-ellation
Copy link
Contributor

@psevcenco-ellation psevcenco-ellation commented Oct 5, 2018

Note: This part is already inluded in a much larger Various improvements PR. However that PR seems to be stale. It might be easier to merge this very simple fix as a separate PR.

Summary: If anyone tries to pipe current version of unescape-js through babel with custom config they will be unable to do so since the local babel config placed inside the package.json will take precedence over any other config.
This is not ideal as not everyone excludes node_modules when running babel.
The fix is very simple: extract babel config into a .babelrc file and exclude this file when publishing to npm.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 06bfaaf on psevcenco-ellation:extract-babel into 7546fb1 on iamakulov:master.

@iamakulov iamakulov merged commit ee48074 into iamakulov:master Oct 5, 2018
@iamakulov
Copy link
Owner

iamakulov commented Oct 5, 2018

Thanks :) Just published as @1.1.1!

@psevcenco-ellation
Copy link
Contributor Author

Thanks :) Just published as 1.1.1!

Thank you! Already using it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants