-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non_qualified
incorrectly null
for gendered emoji
#233
Comments
This now affects 46 emoji in v15.1.0. Iβve updated #217. Can you please review this very easy fix? |
andersk
added a commit
to andersk/emoji-data
that referenced
this issue
Feb 6, 2024
Some fully-qualified emoji have multiple unqualified forms in emoji-test.txt: 1F3F3 FE0F 200D 26A7 FE0F ; fully-qualified # π³οΈββ§οΈ E13.0 transgender flag 1F3F3 200D 26A7 FE0F ; unqualified # π³ββ§οΈ E13.0 transgender flag 1F3F3 FE0F 200D 26A7 ; unqualified # π³οΈββ§ E13.0 transgender flag 1F3F3 200D 26A7 ; unqualified # π³ββ§ E13.0 transgender flag We need to build `$qualified_map` based on the first (fully-qualified) row for each emoji, not the last one that has an FE0F. Fixes iamcal#233. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
iamcal
pushed a commit
that referenced
this issue
Feb 6, 2024
Some fully-qualified emoji have multiple unqualified forms in emoji-test.txt: 1F3F3 FE0F 200D 26A7 FE0F ; fully-qualified # π³οΈββ§οΈ E13.0 transgender flag 1F3F3 200D 26A7 FE0F ; unqualified # π³ββ§οΈ E13.0 transgender flag 1F3F3 FE0F 200D 26A7 ; unqualified # π³οΈββ§ E13.0 transgender flag 1F3F3 200D 26A7 ; unqualified # π³ββ§ E13.0 transgender flag We need to build `$qualified_map` based on the first (fully-qualified) row for each emoji, not the last one that has an FE0F. Fixes #233. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ten emoji with multiple U+FE0F codepoints are incorrectly listed with
"non_qualified": null
, and need to be corrected as follows:name
unified
non_qualified
null
β 1F3CB-200D-2640null
β 1F3CB-200D-2642null
β 1F3CC-200D-2640null
β 1F3CC-200D-2642null
β 1F3F3-200D-26A7null
β 1F441-200D-1F5E8null
β 1F575-200D-2640null
β 1F575-200D-2642null
β 26F9-200D-2640null
β 26F9-200D-2642This is due to a simple bug in
build_map.php
that I fixed a year ago:Please merge this.
The text was updated successfully, but these errors were encountered: