Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non_qualified incorrectly null for gendered emoji #233

Closed
andersk opened this issue Nov 9, 2023 · 1 comment · Fixed by #217
Closed

non_qualified incorrectly null for gendered emoji #233

andersk opened this issue Nov 9, 2023 · 1 comment · Fixed by #217

Comments

@andersk
Copy link
Contributor

andersk commented Nov 9, 2023

Ten emoji with multiple U+FE0F codepoints are incorrectly listed with "non_qualified": null, and need to be corrected as follows:

name unified non_qualified
🏋️‍♀️ WOMAN LIFTING WEIGHTS 1F3CB-FE0F-200D-2640-FE0F null → 1F3CB-200D-2640
🏋️‍♂️ MAN LIFTING WEIGHTS 1F3CB-FE0F-200D-2642-FE0F null → 1F3CB-200D-2642
🏌️‍♀️ WOMAN GOLFING 1F3CC-FE0F-200D-2640-FE0F null → 1F3CC-200D-2640
🏌️‍♂️ MAN GOLFING 1F3CC-FE0F-200D-2642-FE0F null → 1F3CC-200D-2642
🏳️‍⚧️ TRANSGENDER FLAG 1F3F3-FE0F-200D-26A7-FE0F null → 1F3F3-200D-26A7
👁️‍🗨️ EYE IN SPEECH BUBBLE 1F441-FE0F-200D-1F5E8-FE0F null → 1F441-200D-1F5E8
🕵️‍♀️ WOMAN DETECTIVE 1F575-FE0F-200D-2640-FE0F null → 1F575-200D-2640
🕵️‍♂️ MAN DETECTIVE 1F575-FE0F-200D-2642-FE0F null → 1F575-200D-2642
⛹️‍♀️ WOMAN BOUNCING BALL 26F9-FE0F-200D-2640-FE0F null → 26F9-200D-2640
⛹️‍♂️ MAN BOUNCING BALL 26F9-FE0F-200D-2642-FE0F null → 26F9-200D-2642

This is due to a simple bug in build_map.php that I fixed a year ago:

Please merge this.
@andersk andersk mentioned this issue Nov 9, 2023
Merged
@andersk
Copy link
Contributor Author

andersk commented Feb 6, 2024

This now affects 46 emoji in v15.1.0. I’ve updated #217. Can you please review this very easy fix?

andersk added a commit to andersk/emoji-data that referenced this issue Feb 6, 2024
@andersk
Fix missing non_qualified fields for gendered emoji
748c1eb 
Some fully-qualified emoji have multiple unqualified forms in
emoji-test.txt:

    1F3F3 FE0F 200D 26A7 FE0F                              ; fully-qualified     # 🏳️‍⚧️ E13.0 transgender flag
    1F3F3 200D 26A7 FE0F                                   ; unqualified         # 🏳‍⚧️ E13.0 transgender flag
    1F3F3 FE0F 200D 26A7                                   ; unqualified         # 🏳️‍⚧ E13.0 transgender flag
    1F3F3 200D 26A7                                        ; unqualified         # 🏳‍⚧ E13.0 transgender flag

We need to build `$qualified_map` based on the first (fully-qualified)
row for each emoji, not the last one that has an FE0F.

Fixes iamcal#233.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
iamcal pushed a commit that referenced this issue Feb 6, 2024
@andersk @iamcal
Fix missing non_qualified fields for gendered emoji
a340ca1 
Some fully-qualified emoji have multiple unqualified forms in
emoji-test.txt:

    1F3F3 FE0F 200D 26A7 FE0F                              ; fully-qualified     # 🏳️‍⚧️ E13.0 transgender flag
    1F3F3 200D 26A7 FE0F                                   ; unqualified         # 🏳‍⚧️ E13.0 transgender flag
    1F3F3 FE0F 200D 26A7                                   ; unqualified         # 🏳️‍⚧ E13.0 transgender flag
    1F3F3 200D 26A7                                        ; unqualified         # 🏳‍⚧ E13.0 transgender flag

We need to build `$qualified_map` based on the first (fully-qualified)
row for each emoji, not the last one that has an FE0F.

Fixes #233.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing non_qualified fields for gendered emoji andersk/emoji-data
1 participant
@andersk