Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji v11 and Apple Emoji Update #152

Merged
merged 2 commits into from
May 17, 2019
Merged

Conversation

xaviershay
Copy link
Contributor

This builds on #146 and makes the following contributions:

  • Regenerate JSON files.
  • Incorporate short names from Emoji V11.0 and Apple Emoji Update #146 (comment) This is required for the new emoji to flow through to the JSON files.
  • Does not output emoji with null categories. This should probably be fixed before merging to a) provide categories for all missing glyphs (only 4: man/woman super hero/villain), since this is a parsing error - they exist in emoji-test.txt, and b) error more loudly if this is detected in the future.

@jwheare
Copy link
Contributor

jwheare commented May 17, 2019

You can fix the missing categories by changing lines 11/12 of build/data_emoji_names_v11.txt to:

1F9B8{SKIN}-200D-{MALE/FEMALE};{GENDER}_superhero
1F9B9{SKIN}-200D-{MALE/FEMALE};{GENDER}_supervillain

@iamcal
Copy link
Owner

iamcal commented May 17, 2019

This PR is looking really good - thank you for all the work you've put into it.

In the changes to build/download_spec_files.sh, please use explicit versions - otherwise the build will immediately break when v12 comes out. Since each new version of Emoji/Uniccode requires a bunch of work to support, this should ne an explicit change.

I can't tell from the GitHub view, but i'll need to rebuild the sheets after merging the PR, ahead of cutting a new release. Rebuilding the JSON sets new grid positions for the emoji, so all sheets needs to be rebuilt, regardless of whether they have updated images. As new images get added for the non-apple sets, they'll need to get rebuilt again. This takes a long time, so maybe i'll spin up some giant EC2 instances to help chew through them.

@iamcal iamcal merged commit dbcbc4c into iamcal:master May 17, 2019
@iamcal iamcal mentioned this pull request May 17, 2019
@xaviershay
Copy link
Contributor Author

Thank you! I didn't rebuild the sheets. I'm not using that feature so not really familiar with what it is/how it works...

@jwheare jwheare mentioned this pull request May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants