Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from PhantomJS to ChromeHeadless #14

Merged
merged 2 commits into from May 7, 2021
Merged

Switch from PhantomJS to ChromeHeadless #14

merged 2 commits into from May 7, 2021

Conversation

iamcal
Copy link
Owner

@iamcal iamcal commented May 7, 2021

No description provided.

iamcal added 2 commits May 7, 2021 17:19
@iamcal
* updated package versions to ~latest
29c7b9c 
* switch from phantomJS to ChromeHeadless via pupeteer
@iamcal
data rebuild
2024fcb
@iamcal iamcal merged commit 3aae778 into master May 7, 2021
@iamcal iamcal deleted the chrome_headless branch May 7, 2021 17:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 821050573

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.008%) to 48.485%
Files with Coverage Reduction New Missed Lines %
lib/lib_timezones.js 23 48.48%
Totals Coverage Status
Change from base Build 821003081: -3.008%
Covered Lines: 47
Relevant Lines: 90
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamcal @coveralls