Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prepare script #33

Merged
merged 1 commit into from
May 13, 2020
Merged

fix prepare script #33

merged 1 commit into from
May 13, 2020

Conversation

esetnik
Copy link
Contributor

@esetnik esetnik commented May 12, 2020

Resolves #32

vim-plug user can test with:

Plug 'esetnik/coc-diagnostic', {'branch': 'fix-prepare', 'do': 'yarn install --frozen-lockfile'}

@pappasam
Copy link

Build works, but it does generate a warning:

WARNING in ./node_modules/colors/colors.js 219:30-44
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/findup/index.js
 @ ./node_modules/diagnostic-languageserver/lib/common/util.js
 @ ./node_modules/diagnostic-languageserver/lib/handles/handleDiagnostic.js
 @ ./node_modules/diagnostic-languageserver/lib/index.js
 @ ./src/server.ts

@esetnik
Copy link
Contributor Author

esetnik commented May 12, 2020

Build works, but it does generate a warning:

WARNING in ./node_modules/colors/colors.js 219:30-44
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/findup/index.js
 @ ./node_modules/diagnostic-languageserver/lib/common/util.js
 @ ./node_modules/diagnostic-languageserver/lib/handles/handleDiagnostic.js
 @ ./node_modules/diagnostic-languageserver/lib/index.js
 @ ./src/server.ts

Yes I noticed the same. I'm investigating that now. I believe that is a separate issue.

Update, looks to be caused by a very old version of colors https://github.com/Filirom1/findup/blob/master/package.json#L17 depended on by a very old findup package used in diagnostic-languageserver. https://github.com/iamcco/diagnostic-languageserver/blob/master/src/common/util.ts#L9. I guess it should be switched to use the more popular find-up package https://github.com/sindresorhus/find-up#readme.

See:

@iamcco iamcco merged commit e287e98 into iamcco:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build broken on latest commit
3 participants