Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life improvements #11

Merged
merged 9 commits into from
Dec 1, 2019
Merged

Quality of life improvements #11

merged 9 commits into from
Dec 1, 2019

Conversation

mikew
Copy link
Contributor

@mikew mikew commented Dec 1, 2019

Really loving this library, paired with coc.nvim we've got great coverage with linters, formatters, and language servers.

When playing with a few linters, I noticed some issues:

  • not all fixers support stdin/stdout communication
  • when a formatter fails, the file is replaced with the errors output
  • there should be a way to run linters / formatters only when certain files exist

This PR handles those situations.

src/handles/handleDiagnostic.ts Show resolved Hide resolved
src/handles/handleFormat.ts Show resolved Hide resolved
src/handles/handleFormat.ts Show resolved Hide resolved
src/handles/handleFormat.ts Show resolved Hide resolved
src/common/types.ts Show resolved Hide resolved
src/common/types.ts Show resolved Hide resolved
src/handles/handleFormat.ts Show resolved Hide resolved
src/common/util.ts Show resolved Hide resolved
@mikew
Copy link
Contributor Author

mikew commented Dec 1, 2019

I've addressed those changes

@iamcco iamcco merged commit 12de391 into iamcco:master Dec 1, 2019
@iamcco
Copy link
Owner

iamcco commented Dec 1, 2019

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants