Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a day I'll never get back... #363

Merged
merged 8 commits into from
Feb 19, 2020
Merged

a day I'll never get back... #363

merged 8 commits into from
Feb 19, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman commented Feb 19, 2020

What I did

  1. Update .travis.yml to use bionic linux instead of xenial. The latest version of solc has dependency issues when using travis' xenial build.
  2. Fix issue with pytest running tests out of sequence using -k flag.
  3. Handle newly missing source offsets in solc 0.6.3 and a host of related bugs with revert as the final statement in a function.
  4. Refactor some scary code. It's still scary, but it's better than it was before.
  5. Bump dependency versions.
  6. Update changelog, bump version to 1.6.5.

This was supposed to be a simple update to fix the failing travis build, and then it all kinda snowballed... if anyone is watching, I'm sorry for the size of this mess of a pull request.

@iamdefinitelyahuman
Copy link
Member Author

Failing from something new in solc-v0.6.3

@iamdefinitelyahuman iamdefinitelyahuman changed the title update travis to use bionic linux a day I'll never get back... Feb 19, 2020
@iamdefinitelyahuman iamdefinitelyahuman merged commit ddb104c into master Feb 19, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the travis-updates branch February 19, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant