update doc on multiple async_execute behavior
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what it appears, the order of execution when multiple `async_execute` operations are invoked with the same `Connection` is probably not guaranteed. It relies on the task schedule and locking behavior [here](https://github.com/iamed2/LibPQ.jl/blob/2c0547daef005e160aa60cb529d4969a670befbc/src/asyncresults.jl#L270). It probably needs non trivial changes to guarantee an order there. Until then it will be good to update the docs with this fact.
|
I realized it will be good to add some context regarding this PR, and some premise that led to this PR. Added this issue: #278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what it appears, the order of execution when multiple
async_executeoperations are invoked with the sameConnectionis probably not guaranteed. It relies on the task schedule and locking behavior here.It probably needs non trivial changes to guarantee an order there. Until then it will be good to update the docs with this fact.