Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webview-based login support #12

Closed
wants to merge 1 commit into from
Closed

webview-based login support #12

wants to merge 1 commit into from

Conversation

iamhyc
Copy link
Owner

@iamhyc iamhyc commented Sep 18, 2023

TODOs:

service worker proxy verification

vscode did prevent this kind of attack from service worker:

  • service worker cannot fetch worker script due to:
    • webview is in vscode-webview:// origin, and any fetch request to this origin is forbidden;
    • worker script could only be fetched from webviewUri with origin "https://....", which is in different origin from webview;
    • you can pre-fetch worker script as blob url, but service worker is forbidden to load from it;
  • iframe loading from webviewUri is forbidden, so no further worker script can be loaded;
  • iframe loading from blob Uri is possible, but this origin does not parse worker script uri correctly;

@iamhyc iamhyc mentioned this pull request Sep 18, 2023
1 task
@iamhyc
Copy link
Owner Author

iamhyc commented Sep 19, 2023

abandoned due to above restrictions

@iamhyc iamhyc closed this Sep 19, 2023
@iamhyc iamhyc deleted the phantom branch September 19, 2023 06:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant