Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bearer Token Authentification #22

Closed
wants to merge 3 commits into from
Closed

Conversation

Guuz1
Copy link

@Guuz1 Guuz1 commented Apr 25, 2022

Hello Jack Gaino!
I researched a tool to use in a pipeline CI/CD in order to update docs from .md files into Confluence and your tool work very well! But in need for security I wanted to use Personal Token (that can be generated under the personal settings). This is a better approach for me.
So I decided to develop this feature by myself and here I am :D

To add this feature I needed to a little bit refactoring your code as you can see. Maybe one day this code will support OAuth too or an other authentification as-well!

I supposed that will be a minor update so I putted in my version the 1.3.0 but don't hesitate to change it if it not fit your versions organization.

The code was tested with of course the new --bearer-token arg but work as-well with --username arg

Let me know if you're ok with this change and I hope this will be helpful :)

@iamjackg
Copy link
Owner

Hi Gaël! I'll take a look at the merge request and leave some feedback :)

@iamjackg
Copy link
Owner

I took a look at your code. I really appreciate the contribution!

I'd rather not split out the MinimalConfluence object into two subclasses, and there are a couple other things that didn't quite sit right with me. If it's okay with you I'll re-implement this tonight on a separate feature branch, and you can try that out and let me know if it works for your use case.

@iamjackg
Copy link
Owner

I just implemented this and pushed a new version :) I tested it with a couple pages and it worked fine. If you have any issues feel free to open an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants