Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add send_immediately to send "finished" status to trakt after watching >=80% to fix #202 #284

Open
soredake opened this issue Mar 20, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@soredake
Copy link

If this option is added, #202 can be considered as fixed, as finished state will be sent before changing file.

@iamkroot
Copy link
Owner

My main hesitancy with this is how to deduplicate the scrobbles. If we've already added it to history at 80% and then continue watching we need to remember not to scrobble again. And this needs to be persisted across many plays (you can close a file at 85%, come back tomorrow and play the rest of it.) Makes the logic a lot more complicated than what it is today.

If someone is willing to contribute with a simple PR, I'm willing to review.

@iamkroot iamkroot added enhancement New feature or request help wanted Extra attention is needed labels Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants