fix: round durations to millisecond precision for ISO string (#2367)

iamkun · Jul 5, 2023 · 890a17a · 890a17a
1 parent 1fe1b1d
commit 890a17a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/plugin/duration/index.js b/src/plugin/duration/index.js
@@ -139,7 +139,7 @@ class Duration {
 
     let seconds = this.$d.seconds || 0
     if (this.$d.milliseconds) {
-      seconds += this.$d.milliseconds / 1000
+      seconds += Math.round(this.$d.milliseconds) / 1000
     }
 
     const S = getNumberUnitFormat(seconds, 'S')

diff --git a/test/plugin/duration.test.js b/test/plugin/duration.test.js
@@ -70,6 +70,13 @@ describe('Creating', () => {
   it('convert to milliseconds', () => {
     expect(+dayjs.duration(100)).toBe(100)
   })
+  it('handles rounding to millisecond precision', () => {
+    expect(dayjs.duration(2 / 3).toISOString()).toBe('PT0.001S')
+  })
+  it('should handle round with millisecond precision when negative', () => {
+    expect(dayjs.duration(1000.5).toISOString()).toBe('PT1.001S')
+    expect(dayjs.duration(-1000.5).toISOString()).toBe('-PT1S')
+  })
 })
 
 describe('Parse ISO string', () => {