Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The document description is strange. #204

Closed
ujuc opened this issue May 29, 2018 · 2 comments
Closed

The document description is strange. #204

ujuc opened this issue May 29, 2018 · 2 comments

Comments

@ujuc
Copy link
Contributor

ujuc commented May 29, 2018

Hi,

I am currently translating in Korean.
I see strange discription.

This line, "### As JSON .toJSON()" section.

cca5014#diff-a8c2016c6f80f463e1a2006360e6abf8L364

This commit change.

-Serializing a `Dayjs` object to JSON, will return an ISO8601 string.
+Returns an ISO8601 string.

and

b1e7ec3#diff-a8c2016c6f80f463e1a2006360e6abf8L309

-Returns an ISO8601 string.
+Returns the `Dayjs` formatted in an ISO8601 `string`.

remove "Serializing a Dayjs objwct to JSON".
Did anything change during this period?

@iamkun
Copy link
Owner

iamkun commented May 29, 2018

Thanks @ujuc for the translation.

The final words in our Doc is just mean that you will get a formatted ISO8601 string from your current Dayjs Object.

Is this what you mean?

@ujuc
Copy link
Contributor Author

ujuc commented May 29, 2018

Yes, Ok 🤣

@iamkun iamkun closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants