Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix formatting months in russian #577

Closed
VBagmut opened this issue Apr 21, 2019 · 4 comments · Fixed by #581
Closed

Please fix formatting months in russian #577

VBagmut opened this issue Apr 21, 2019 · 4 comments · Fixed by #581
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released

Comments

@VBagmut
Copy link

VBagmut commented Apr 21, 2019

Issuehunt badges

Describe the bug
Long description of months (MMMM) are showing not correctly.

Expected behavior
I created comparison, so you can see what it should look like. Also I've included possible fix (different months field in object fixedRuLocale) - https://runkit.com/bagmutva/5cbc390d7da00600130f419c
For now in my work project we're using dayjs and moment. Unfortunately because of this bug we using moment for formatting long dates. But we want to use only one library - dayjs. So please fix this.

Information

  • Day.js Version 1.8.12
  • OS: MacOS Mojave 10.14.4
  • Browser: Google Chrome 73.0.3683.86

IssueHunt Summary

iamkun iamkun has been rewarded.

Backers (Total: $50.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@ghost
Copy link

ghost commented Apr 21, 2019

This might be a breaking change of Day.js.

After searching:

In this example, in Russian language a stand-alone month is in the nominative case ("январь"), and formatting month is in the genitive case ("января" as in "1-е января"). Notice the different endings:

That is to say we should add two different format string for format and standalone type of different formatting cases.

Any good idea, guys?

@IssueHuntBot
Copy link

@IssueHunt has funded $50.00 to this issue.


@iamkun
Copy link
Owner

iamkun commented Apr 26, 2019

🎉 This issue has been resolved in version 1.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@issuehunt-oss
Copy link

issuehunt-oss bot commented Aug 12, 2019

@iamkun has rewarded $45.00 to @iamkun. See it on IssueHunt

  • 💰 Total deposit: $50.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $5.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants