Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duration plugin supports parse ISO string with week (W) #950

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Jul 2, 2020

fix #949

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #950 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       167           
  Lines         1423      1423           
  Branches       305       305           
=========================================
  Hits          1423      1423           
Impacted Files Coverage Δ
src/plugin/duration/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d4740...701061a. Read the comment docs.

@iamkun iamkun merged commit f0fc12a into dev Jul 2, 2020
iamkun pushed a commit that referenced this pull request Jul 2, 2020
## [1.8.29](v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](#950)) ([f0fc12a](f0fc12a))
* LocaleData plugin supports locale order ([#938](#938)) ([62f429d](62f429d)), closes [#936](#936)
* Update type definition to support array format ([#945](#945)) ([81d4740](81d4740)), closes [#944](#944)
* Update type definition to support strict mode ([#951](#951)) ([8d54f3f](8d54f3f))
@iamkun
Copy link
Owner Author

iamkun commented Jul 2, 2020

🎉 This PR is included in version 1.8.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 2, 2020
@iamkun iamkun deleted the fix/duration-week branch July 29, 2020 02:42
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Day.js returns wrong duration object when created using ISO 8601 duration with WEEK designator (W)
1 participant