Fixes casing for en-SG locale name. #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1048 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 172
Lines 1522 1546 +24
Branches 321 328 +7
=========================================
+ Hits 1522 1546 +24
Continue to review full report at Codecov.
|
|
we also have to update the filename accordingly. |
|
This is somehow a breaking change. Let's make it to 1.9.0 |
iamkun
pushed a commit
that referenced
this pull request
Sep 28, 2020
# [1.9.0](v1.8.36...v1.9.0) (2020-09-28) ### Bug Fixes * Add `setDefault` typing to timezone.d.ts ([#1057](#1057)) ([c0f0886](c0f0886)) * fix DST bug in utc plugin ([#1053](#1053)) ([3d73543](3d73543)) * Fix optional type for timezone plugin ([#1081](#1081)) ([a6ebcf2](a6ebcf2)), closes [#1079](#1079) * Fix timezone plugin conversion bug ([#1073](#1073)) ([16816a3](16816a3)) * update duration plugin type file ([#1065](#1065)) ([94af9af](94af9af)) * update timezone plugin to support getting offset name e.g. EST ([#1069](#1069)) ([cbb755e](cbb755e)) * update utc plugin to support keepLocalTime `.utc(true)` ([#1080](#1080)) ([5ce4e0d](5ce4e0d)) ### Features * Correct casing for en-sg locale name ([#1048](#1048)) ([2edaddc](2edaddc))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28) ### Bug Fixes * Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([c0f0886](iamkun/dayjs@c0f0886)) * fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([3d73543](iamkun/dayjs@3d73543)) * Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([a6ebcf2](iamkun/dayjs@a6ebcf2)), closes [#1079](iamkun/dayjs#1079) * Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([16816a3](iamkun/dayjs@16816a3)) * update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([94af9af](iamkun/dayjs@94af9af)) * update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([cbb755e](iamkun/dayjs@cbb755e)) * update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([5ce4e0d](iamkun/dayjs@5ce4e0d)) ### Features * Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([2edaddc](iamkun/dayjs@2edaddc))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
# [1.9.0](iamkun/dayjs@v1.8.36...v1.9.0) (2020-09-28) ### Bug Fixes * Add `setDefault` typing to timezone.d.ts ([#1057](iamkun/dayjs#1057)) ([c0f0886](iamkun/dayjs@c0f0886)) * fix DST bug in utc plugin ([#1053](iamkun/dayjs#1053)) ([3d73543](iamkun/dayjs@3d73543)) * Fix optional type for timezone plugin ([#1081](iamkun/dayjs#1081)) ([a6ebcf2](iamkun/dayjs@a6ebcf2)), closes [#1079](iamkun/dayjs#1079) * Fix timezone plugin conversion bug ([#1073](iamkun/dayjs#1073)) ([16816a3](iamkun/dayjs@16816a3)) * update duration plugin type file ([#1065](iamkun/dayjs#1065)) ([94af9af](iamkun/dayjs@94af9af)) * update timezone plugin to support getting offset name e.g. EST ([#1069](iamkun/dayjs#1069)) ([cbb755e](iamkun/dayjs@cbb755e)) * update utc plugin to support keepLocalTime `.utc(true)` ([#1080](iamkun/dayjs#1080)) ([5ce4e0d](iamkun/dayjs@5ce4e0d)) ### Features * Correct casing for en-sg locale name ([#1048](iamkun/dayjs#1048)) ([2edaddc](iamkun/dayjs@2edaddc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the way consumer can work with locales programmatically it is better to unify all the locale names to single format.
All other locales are lower case, only Singapore is en-SG