New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin range #1580
base: dev
Are you sure you want to change the base?
feat: add plugin range #1580
Conversation
imwh0im
commented
Jul 16, 2021
- [Feature Request] - Date Ranges Overlap #1537
This reverts commit 4554cbe.
- iamkun#1558 - add validation for invalid date in plugin advancedFormat
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1580 +/- ##
=======================================
Coverage 99.77% 99.78%
=======================================
Files 183 184 +1
Lines 2262 2289 +27
Branches 642 649 +7
=======================================
+ Hits 2257 2284 +27
Misses 5 5
☔ View full report in Codecov by Sentry. |
Would it be worth naming this 'Period' rather than 'Range'? I'm aware that Moment plugin was called 'range', but usually in programming languages, 'range' is used to generate a sequence of things, whereas this feature is about creating a date 'period'. The Moment plugin covers the term 'range' by also being iterable, which this could implement. I raise this, as #1162 asked for the ability to generate date ranges, and I've got a plugin in the works that would be called via |
Co-authored-by: Alex <wieland.alex1996@gmail.com>
Passed |
Co-authored-by: David <david@hmnd.io>
Co-authored-by: David <david@hmnd.io>
Co-authored-by: David <david@hmnd.io>
@hmnd Thanks your suggested |
https://github.com/imwh0im/dayjs-range-extend I've awaited #1580, and I can't wait no more. range function module name is dayjs-range-extend, this Module make below things possible.
i've mentioned, i couldn't wait anymore range function. However, want use range function from Day.js. |
@iamkun still no plans to merge this? :') |
Looking forward for this feature, so needed! |
Is this project still maintained @iamkun ? |
In the absence of this being merged I'm going to have to use @imwh0im plugin... I also second this as being really important to merge if at all possible - it's a really useful tool to have as I am just migrating away from Moment (finally) :) |
What's going on with this PR? |
Any news? |
Agree with others... Please merge |
|
When can we expect this to be merged? |