fix: +00:00 timezone bug #1678
Open
fix: +00:00 timezone bug #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1678 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 1996 1997 +1
Branches 507 508 +1
=========================================
+ Hits 1996 1997 +1
Continue to review full report at Codecov.
|
NamPNQ
reviewed
Nov 15, 2021
| @@ -114,7 +114,8 @@ export default (option, Dayjs, dayjs) => { | |||
|
|
|||
| proto.valueOf = function () { | |||
| const addedOffset = !this.$utils().u(this.$offset) | |||
| ? this.$offset + (this.$x.$localOffset || (new Date()).getTimezoneOffset()) : 0 | |||
There was a problem hiding this comment.
I think you can use ?? operator to fix this
|
Hey @iamkun is there any plan to merge this fix? I'm having the same problem with Europe/London. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have +00:00 timezone offset like 'Europe/London" dayjs gets users timezone offset, which causes incorrect time showing in different cases.
Example
Current behavior:
dayjs('2021-10-31T15:00:00+00:00').tz('Europe/London').format() // 2021-10-31T15:00:00ZBehavior after fix:
dayjs('2021-10-31T15:00:00+00:00').tz('Europe/London').format() // 2021-10-31T15:00:00+00:00