Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weekdaysMin of vi's locale #2307

Closed
wants to merge 2 commits into from
Closed

Update weekdaysMin of vi's locale #2307

wants to merge 2 commits into from

Conversation

anhtuan219
Copy link

Hi, I'm working on a personal project and I want to make a date time picker input in Vietnamese. Currently, I'm using the date time picker of Material UI with date library dayjs (which is one of the best date libraries in my opinion :)). Everything it's great, but I noticed that label for weekdays (from Monday to Saturday) is just a letter 'T' (like the image below) and I can't distinguish weekdays (even though I'm Vietnamese). It seems that Material UI uses just the first letter of weekdaysMin for the label. I fixed that problem by customizing the locale. I think this could make a difference between weekdaysShort and weekdaysMin so I made this pull request. I don't know if my solution suits the library so please let me know if this change is not acceptable, thank you
before

@iamkun
Copy link
Owner

iamkun commented Jun 22, 2023

if the UI lib is using weekdaysMin it should display at least "T2" is it?

also, the locale is the same as moment.js and it should be correct, IMHO

https://github.com/moment/moment/blob/develop/locale/vi.js

@anhtuan219
Copy link
Author

OK, thanks for the reply. I can overwrite the locale in my project to show what I need so I will close this PR

@anhtuan219 anhtuan219 closed this Jul 1, 2023
@anhtuan219 anhtuan219 deleted the patch-1 branch July 1, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants